Skip to content

Change OperatorUpgradeable type to string and add utils func #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

dinhxuanvu
Copy link
Member

Use string as OperatorUpgradeable type instead of intermediate
type ConditionType.

Add utils func FindConditionType to look up Condition type.

Signed-off-by: Vu Dinh [email protected]

Use string as OperatorUpgradeable type instead of intermediate
type ConditionType.

Add utils func FindConditionType to look up Condition type.

Signed-off-by: Vu Dinh <[email protected]>
Copy link
Member

@awgreene awgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2020
@dinhxuanvu dinhxuanvu merged commit 4247282 into operator-framework:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants