Skip to content

Guidelines for Contribution and PR review. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 16, 2021
Merged

Guidelines for Contribution and PR review. #2

merged 3 commits into from
Feb 16, 2021

Conversation

laxmikantbpandhare
Copy link
Member

Guidelines for Contribution and PR review.

Copy link
Member

@theishshah theishshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added sections look good, just the one nit in the codes style.

Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes. Overall nicely done.

@theishshah theishshah merged commit 403d619 into operator-framework:main Feb 16, 2021
@laxmikantbpandhare laxmikantbpandhare mentioned this pull request Feb 16, 2021
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants