bugfix: add domain sanitation #82
Merged
+108
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds sanitization of the domain so that legal java packages can be created. Adds a flag to disable to the logic if necessary fixes operator-framework#81 Signed-off-by: Bryce Palmer <[email protected]>
everettraven
changed the title
laxmikantbpandhare
requested review from
jmrodri,
laxmikantbpandhare and
metacosm
|
Instead of deactivating the sanitation, it might be better to only sanitize the package name and leave the domain name intact. Presumably, the domain name shouldn't change, only the package name. |
That makes sense. I will make some changes to reflect this. Thanks @metacosm for pointing this out! |
Signed-off-by: Bryce Palmer <[email protected]>
|
As of commit 8b73706 this should now only sanitize the package name and leave the domain unchanged |
metacosm
reviewed
May 2, 2022
| @@ -62,19 +62,19 @@ func (s *apiScaffolder) Scaffold() error { | |||
| var createAPITemplates []machinery.Builder | |||
| createAPITemplates = append(createAPITemplates, | |||
| &model.Model{ | |||
| Package: util.ReverseDomain(s.config.GetDomain()), | |||
| Package: util.ReverseDomain(util.SanitizeDomain(s.config.GetDomain())), | |||
There was a problem hiding this comment.
Not relevant to the current PR but maybe it'd make sense to compute these (and the class name) only once.
metacosm
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds sanitization of the domain so that legal java packages can be created. Adds a flag to
disable to the logic if necessary
fixes #81
Signed-off-by: Bryce Palmer [email protected]