Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefile changes for addition of run bundle in Java Plugin. #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile changes for addition of run bundle in Java Plugin. #84
Changes from all commits
52f055f
7605a9b
b8754b2
c434142
7d5502b
9025bf3
9d99a04
484436f
30e8a12
91a283f
aa82175
d2a0acd
d038ebe
078ea6d
276d8aa
c1c01df
2a0662a
9f3c96e
67c8ed6
5048145
713f109
28a3ba6
13652c9
ebbab67
407c2a1
1e55597
203f444
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't hold this PR up but I think we need to make this depend on a build target.
Basically in our other projects if we run
make bundle
it will do a generation and create the manifests required. But in Java, it won't. But that's because we're not calling anything frommake bundle
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes agree, we must add
mvn install
before generating the bundle else it will fail if the User is not compiled the project before generating the bundle manifest. Let me try to add this to the existing logic.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question here, when the User tries the below command at that moment itself it will generate the
/target
directory.make docker-build docker-push IMG=quay.io/YOURUSER/memcached-quarkus-operator:0.0.1
Do you still think we still need to add
mvn clean install
in the bundle structure?