Skip to content

modified memcached operator according to run bundle integration #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 3, 2022
Merged

modified memcached operator according to run bundle integration #86

merged 4 commits into from
Jun 3, 2022

Conversation

laxmikantbpandhare
Copy link
Member

Modified Memcached operator according to run bundle integration and working on updating tutorial

@laxmikantbpandhare laxmikantbpandhare added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2022
@laxmikantbpandhare laxmikantbpandhare self-assigned this Jun 3, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2022
@laxmikantbpandhare laxmikantbpandhare added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 3, 2022
@laxmikantbpandhare
Copy link
Member Author

Yet to update Tutorial. Work is in Progress.

@laxmikantbpandhare laxmikantbpandhare removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 3, 2022
@laxmikantbpandhare
Copy link
Member Author

laxmikantbpandhare commented Jun 3, 2022 •
edited
Loading

Updated the tutorial that adds steps to run an Operator with OLM run Bundle.

jmrodri
jmrodri approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some really minor edits in the doc, but we can probably leave it as is.

everettraven
everettraven approved these changes Jun 3, 2022
View reviewed changes
Copy link
Collaborator

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one nit (non-blocking).

jmrodri
jmrodri approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2022
@laxmikantbpandhare laxmikantbpandhare merged commit 721a0c4 into operator-framework:main Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrodri jmrodri jmrodri approved these changes

@metacosm metacosm Awaiting requested review from metacosm

@everettraven everettraven Awaiting requested review from everettraven

Assignees

@jmrodri jmrodri

@laxmikantbpandhare laxmikantbpandhare

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laxmikantbpandhare @jmrodri @everettraven