Skip to content

bug for command addition in Makefile - Bug 2099603 #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2022
Merged

bug for command addition in Makefile - Bug 2099603 #93

merged 1 commit into from
Jun 21, 2022

Conversation

laxmikantbpandhare
Copy link
Member

Description of problem:
Bundle version is overwrite by a fixed version (0.1.1) in Makefile for java type operator.

Version-Release number of selected component (if applicable):
operator-sdk version: "v1.20.0-ocp", commit: "4db4731ae75f2cccae951dd7ed98484662179c55", kubernetes version: "v1.24.1", go version: "go1.18.3", GOOS: "linux", GOARCH: "amd64"

How reproducible:
always

Steps to Reproduce:
1.$operator-sdk init --plugins quarkus --domain example.com --project-name memcached-quarkus-operator
2.$operator-sdk create api --plugins quarkus --group cache --version v1 --kind Memcached

Actual results:
$cat Makefile
##@Bundle
.PHONY: bundle
bundle: ## Generate bundle manifests and metadata, then validate generated files.

marker

cat target/kubernetes/memcacheds.cache.example.com-v1.yml target/kubernetes/kubernetes.yml | operator-sdk generate bundle -q --overwrite --version 0.1.1 --default-channel=stable --channels=stable --package=memcached-quarkus-operator
operator-sdk bundle validate ./bundle

Expected results:
##@Bundle
.PHONY: bundle
bundle: ## Generate bundle manifests and metadata, then validate generated files.

marker

cat target/kubernetes/memcacheds.cache.example.com-v1.yml target/kubernetes/kubernetes.yml | operator-sdk generate bundle -q --overwrite --version $(VERSION) $(BUNDLE_METADATA_OPTS)
operator-sdk bundle validate ./bundle

Additional info:

Copy link
Collaborator

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2022
@laxmikantbpandhare
Copy link
Member Author

Steps Followed and ran the operator for new changes.

laxmikantbhaskarpandhare@lpandhar-mac memcached-quarkus-operator % operator-sdk run bundle docker.io/013859989/memcached-quarkus-operator-bundle:v0.0.1 --timeout=10m0s
INFO[0062] Creating a File-Based Catalog of the bundle "docker.io/013859989/memcached-quarkus-operator-bundle:v0.0.1" 
INFO[0100] Generated a valid File-Based Catalog         
INFO[0101] Created registry pod: docker-io-013859989-memcached-quarkus-operator-bundle-v0-0-1 
INFO[0101] Created CatalogSource: memcached-quarkus-operator-catalog 
INFO[0101] OperatorGroup "operator-sdk-og" created      
INFO[0101] Created Subscription: memcached-quarkus-operator-v0-0-1-sub 
INFO[0105] Approved InstallPlan install-67f2c for the Subscription: memcached-quarkus-operator-v0-0-1-sub 
INFO[0105] Waiting for ClusterServiceVersion "default/memcached-quarkus-operator.v0.0.1" to reach 'Succeeded' phase 
INFO[0105]   Waiting for ClusterServiceVersion "default/memcached-quarkus-operator.v0.0.1" to appear 
INFO[0111]   Found ClusterServiceVersion "default/memcached-quarkus-operator.v0.0.1" phase: Pending 
INFO[0112]   Found ClusterServiceVersion "default/memcached-quarkus-operator.v0.0.1" phase: Installing 
INFO[0143]   Found ClusterServiceVersion "default/memcached-quarkus-operator.v0.0.1" phase: Succeeded 
INFO[0143] OLM has successfully installed "memcached-quarkus-operator.v0.0.1" 
laxmikantbhaskarpandhare@lpandhar-mac memcached-quarkus-operator % 

@laxmikantbpandhare laxmikantbpandhare merged commit d474ba0 into operator-framework:main Jun 21, 2022
@laxmikantbpandhare laxmikantbpandhare deleted the bugfix-version branch June 29, 2022 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants