fix: remove potentially problematic default implementation

Signed-off-by: Chris Laprun <[email protected]>

Author: metacosm

Diff for: operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ResourceConfiguration.java

@@ -26,9 +26,7 @@ default String getResourceTypeName() {
     return ReconcilerUtils.getResourceTypeName(getResourceClass());
   }
 
-  default InformerConfigHolder<R> getInformerConfig() {
-    return InformerConfigHolder.DEFAULT_EVENT_SOURCE_CONFIG;
-  }
+  InformerConfigHolder<R> getInformerConfig();
 
   default Optional<OnAddFilter<? super R>> onAddFilter() {
     return Optional.ofNullable(getInformerConfig().getOnAddFilter());

Diff for: operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/InformerConfigHolder.java

@@ -18,12 +18,6 @@
 
 @SuppressWarnings("unused")
 public class InformerConfigHolder<R extends HasMetadata> {
-  @SuppressWarnings("rawtypes")
-  public static final InformerConfigHolder DEFAULT_CONTROLLER_CONFIG =
-      InformerConfigHolder.builder().buildForController();
-  @SuppressWarnings("rawtypes")
-  public static final InformerConfigHolder DEFAULT_EVENT_SOURCE_CONFIG =
-      InformerConfigHolder.builder().buildForInformerEventSource();
   private final Builder builder = new Builder();
   private String name;
   private Set<String> namespaces;

Diff for: operator-framework-core/src/test/java/io/javaoperatorsdk/operator/api/config/ResourceConfigurationTest.java

@@ -6,12 +6,17 @@
 import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
+import io.fabric8.kubernetes.api.model.HasMetadata;
 import io.javaoperatorsdk.operator.api.reconciler.Constants;
+import io.javaoperatorsdk.operator.processing.dependent.kubernetes.InformerConfigHolder;
 
 import static org.junit.jupiter.api.Assertions.*;
 
 class ResourceConfigurationTest {
 
+  public static final ResourceConfiguration<HasMetadata> DEFAULT =
+      () -> InformerConfigHolder.builder().buildForInformerEventSource();
+
   @Test
   void allNamespacesWatched() {
     assertThrows(IllegalArgumentException.class,
@@ -46,14 +51,14 @@ void currentNamespaceWatched() {
 
   @Test
   void nullLabelSelectorByDefault() {
-    assertNull(new ResourceConfiguration<>() {}.getLabelSelector());
+    assertNull(DEFAULT.getLabelSelector());
   }
 
   // todo: fix me
   @Disabled
   @Test
   void shouldWatchAllNamespacesByDefault() {
-    assertTrue(new ResourceConfiguration<>() {}.watchAllNamespaces());
+    assertTrue(DEFAULT.watchAllNamespaces());
   }
 
   @Test