Skip to content

Deleting Garbage Collected Dependent resource in Workflows if Reconcile Precondition Not Holds #1869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
csviri opened this issue Apr 25, 2023 · 0 comments · Fixed by #1871
Closed

Deleting Garbage Collected Dependent resource in Workflows if Reconcile Precondition Not Holds #1869

csviri opened this issue Apr 25, 2023 · 0 comments · Fixed by #1871
Assignees
@csviri
Labels
kind/feature Categorizes issue or PR as related to a new feature. workflows

Comments

@csviri
Copy link
Collaborator

csviri commented Apr 25, 2023 •
edited
Loading

Currently GarbageCollected dependent resource are not deleted in the workflow if a precondition does not hold. Usually this is not a problem, since those resources should not be garbage collected, rather deleted so an ordering can be assured. But would be more correct actually delete those resources (thus just ignore garbage collected (GC), if a DR is deleter just delete it).

For example we had a case when a top level dependent resource was a GC, and had a reconcile precondition, but currently not deleted. This is definitely wrong since, there is no reason this resource should not be deleted in this case.
@csviri csviri self-assigned this Apr 25, 2023
@csviri csviri changed the title Deleting Garbage Collected Dependent resource in Workflows if Reconcile Precondition not holds Deleting Garbage Collected Dependent resource in Workflows if Reconcile Precondition Not Holds Apr 25, 2023
@csviri csviri added workflows kind/feature Categorizes issue or PR as related to a new feature. labels Apr 25, 2023
@csviri csviri linked a pull request Apr 25, 2023 that will close this issue
improve: delete GC dependent if reconcile precondition not met #1871
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csviri csviri

Labels
kind/feature Categorizes issue or PR as related to a new feature. workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improve: delete GC dependent if reconcile precondition not met operator-framework/java-operator-sdk
1 participant
@csviri