Skip to content

improve: delete GC dependent if reconcile precondition not met #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 26, 2023
Merged

improve: delete GC dependent if reconcile precondition not met #1871

merged 4 commits into from
Apr 26, 2023

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Apr 25, 2023

No description provided.

@csviri csviri self-assigned this Apr 25, 2023
@csviri csviri requested a review from metacosm April 25, 2023 11:31
@csviri csviri linked an issue Apr 25, 2023 that may be closed by this pull request
Deleting Garbage Collected Dependent resource in Workflows if Reconcile Precondition Not Holds #1869
Closed
@csviri csviri changed the title improve: reconcile not met gc improve: delete GC dependent if reconcile precondition not met Apr 25, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@csviri csviri merged commit e63b720 into main Apr 26, 2023
@csviri csviri deleted the reconcile-not-met-gc branch April 26, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

Assignees

@csviri csviri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deleting Garbage Collected Dependent resource in Workflows if Reconcile Precondition Not Holds
2 participants
@csviri @metacosm