Skip to content

Consider moving the prepareEventSources directly to Reconciler in v5 #2029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
csviri opened this issue Aug 24, 2023 · 0 comments · Fixed by #2257
Closed

Consider moving the prepareEventSources directly to Reconciler in v5 #2029

csviri opened this issue Aug 24, 2023 · 0 comments · Fixed by #2257
Labels
needs-discussion Issue needs to be discussed more before working on it
Milestone
5.0

Comments

@csviri
Copy link
Collaborator

csviri commented Aug 24, 2023

Currently this handled by a separate interface: EventSourceInitializer, but if properly implemented in the overwhelming number of cases the controller will define event sources. Moving it back, would guide the developers from the beginning to go that direction.
@csviri csviri added this to the 5.0 milestone Aug 24, 2023
@csviri csviri added the needs-discussion Issue needs to be discussed more before working on it label Aug 24, 2023
@csviri csviri linked a pull request Mar 1, 2024 that will close this issue
improve: remove EventSourceInitializer #2257
Merged
@csviri csviri closed this as completed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-discussion Issue needs to be discussed more before working on it
Projects
None yet
Milestone
5.0
Development

Successfully merging a pull request may close this issue.

improve: remove EventSourceInitializer operator-framework/java-operator-sdk
1 participant
@csviri