improve: remove EventSourceInitializer #2257

csviri · 2024-03-01T12:53:06Z

Move EventSourceIntiailizer directly to Reconciler. Based on the patter, if properly done, there will be always EventSource. Still can return empty map.

csviri · 2024-03-01T12:55:46Z

We should consider (I'm leaning to this) not even provide a default implementation, although might be confusing for someone who starts first, that is that part not simple to understand first (like how Informers works and why essential), but at least moves users news to operators to good direction.

what do you tink @metacosm @jcechace ?

metacosm · 2024-03-01T13:15:19Z

...ator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/Reconciler.java

+   * @param eventSources to name
+   * @return even source with default names
+   */
+  static Map<String, EventSource> nameEventSources(EventSource... eventSources) {


I would prefer that we move all these methods to a different utilty class. They have nothing to do with Reconciler itself and pollute its API, imo.

Will move it for now, was thinking to also have have EventSources "Named" like now with the Dependent Resources. Will make a separate PR. That would make these methods basically obsolete.

Added EventSourceUtils.

metacosm · 2024-03-01T13:17:46Z

...work-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/EventSource.java

- * not changed). To register EventSources with so that your reconciler is triggered, please make
- * your reconciler implement
- * {@link io.javaoperatorsdk.operator.api.reconciler.EventSourceInitializer}.
+ * not changed). To register EventSources with so that your reconciler is triggered.


This doesn't make sense anymore.

metacosm · 2024-03-01T13:20:39Z

We should consider (I'm leaning to this) not even provide a default implementation, although might be confusing for someone who starts first, that is that part not simple to understand first (like how Informers works and why essential), but at least moves users news to operators to good direction.

what do you tink @metacosm @jcechace ?

The default implementation should stay because, imo, most people will never need to implement this method. What would the implementation be for someone who only uses managed workflows, for example?

csviri · 2024-03-01T14:55:56Z

The default implementation should stay because, imo, most people will never need to implement this method. What would the implementation be for someone who only uses managed workflows, for example?

ok that is good argument, to keep the default impl. (Although most is probably a strong word, since that is the case only for simple controllers)

metacosm

The documentation needs updates.

docs/documentation/dependent-resources.md

Signed-off-by: Attila Mészáros <[email protected]>

Signed-off-by: Chris Laprun <[email protected]>

Signed-off-by: Attila Mészáros <[email protected]> Signed-off-by: Chris Laprun <[email protected]> Co-authored-by: Chris Laprun <[email protected]>

Signed-off-by: Attila Mészáros <[email protected]> Signed-off-by: Chris Laprun <[email protected]> Co-authored-by: Chris Laprun <[email protected]> Signed-off-by: Attila Mészáros <[email protected]>

openshift-ci bot requested review from adam-sandor and andreaTP March 1, 2024 12:53

csviri linked an issue Mar 1, 2024 that may be closed by this pull request

Consider moving the prepareEventSources directly to Reconciler in v5 #2029

Closed

metacosm reviewed Mar 1, 2024

View reviewed changes

csviri requested a review from metacosm March 4, 2024 09:02

csviri force-pushed the remove-event-source-initializer branch from cdc399c to 1ea7b72 Compare March 6, 2024 08:12

csviri force-pushed the next branch from f2be686 to c281903 Compare March 7, 2024 10:48

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2024

metacosm force-pushed the remove-event-source-initializer branch from c076f9f to 75378b3 Compare March 11, 2024 17:19

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 11, 2024

metacosm force-pushed the remove-event-source-initializer branch from 75378b3 to c076f9f Compare March 11, 2024 17:43

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 11, 2024

csviri force-pushed the remove-event-source-initializer branch from c076f9f to 43f3002 Compare March 11, 2024 17:53

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 11, 2024

metacosm requested changes Mar 11, 2024

View reviewed changes

docs/documentation/dependent-resources.md Outdated Show resolved Hide resolved

csviri force-pushed the next branch from e0a622f to c67ca26 Compare March 11, 2024 19:19

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2024

metacosm approved these changes Mar 12, 2024

View reviewed changes

csviri and others added 8 commits March 12, 2024 14:13

improve: remove EventSourceInitializer

b899904

Signed-off-by: Attila Mészáros <[email protected]>

fix docs

c0b61fb

Signed-off-by: Attila Mészáros <[email protected]>

introduce event source utils

d59d145

Signed-off-by: Attila Mészáros <[email protected]>

docs update

6909189

Signed-off-by: Attila Mészáros <[email protected]>

docs: improve wording

1f3387d

Signed-off-by: Chris Laprun <[email protected]>

fix: actually remove EventSourceInitializer

e0888b8

Signed-off-by: Chris Laprun <[email protected]>

fix(docs): update standalone example documentation

7c3fb27

Signed-off-by: Chris Laprun <[email protected]>

refactor: improve wording

8c846cf

Signed-off-by: Chris Laprun <[email protected]>

csviri merged commit 106f14b into next Mar 12, 2024
20 checks passed

csviri deleted the remove-event-source-initializer branch March 12, 2024 13:43

metacosm mentioned this pull request Mar 21, 2024

refactor: make ManagedWorkflowSupport public to be able to reuse it #2307

Closed

csviri added a commit that referenced this pull request Apr 10, 2024

improve: remove EventSourceInitializer (#2257)

5d63020

Signed-off-by: Attila Mészáros <[email protected]> Signed-off-by: Chris Laprun <[email protected]> Co-authored-by: Chris Laprun <[email protected]>

metacosm added a commit that referenced this pull request Apr 10, 2024

improve: remove EventSourceInitializer (#2257)

0dc1fd0

Signed-off-by: Attila Mészáros <[email protected]> Signed-off-by: Chris Laprun <[email protected]> Co-authored-by: Chris Laprun <[email protected]>

metacosm added a commit that referenced this pull request Apr 11, 2024

improve: remove EventSourceInitializer (#2257)

4875c08

Signed-off-by: Attila Mészáros <[email protected]> Signed-off-by: Chris Laprun <[email protected]> Co-authored-by: Chris Laprun <[email protected]>

csviri added a commit that referenced this pull request May 17, 2024

improve: remove EventSourceInitializer (#2257)

748fb4e

Signed-off-by: Attila Mészáros <[email protected]> Signed-off-by: Chris Laprun <[email protected]> Co-authored-by: Chris Laprun <[email protected]>

csviri mentioned this pull request Aug 14, 2024

improve: replace jenvtest with kube-api-test from fabric8 client #2497

Merged

csviri mentioned this pull request Sep 17, 2024

feat: context getSecondary resource is activation condition aware #2532

Merged

This was referenced Dec 3, 2024

chore: fabri8 client to v7.0.0 #2616

Merged

docs: migration guide as blogpost refactor #2618

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

improve: remove EventSourceInitializer #2257

improve: remove EventSourceInitializer #2257

csviri commented Mar 1, 2024

csviri commented Mar 1, 2024

metacosm Mar 1, 2024

csviri Mar 4, 2024

csviri Mar 4, 2024

metacosm Mar 1, 2024

csviri Mar 4, 2024

metacosm commented Mar 1, 2024

csviri commented Mar 1, 2024 •

edited

Loading

metacosm left a comment

improve: remove EventSourceInitializer #2257

improve: remove EventSourceInitializer #2257

Conversation

csviri commented Mar 1, 2024

csviri commented Mar 1, 2024

metacosm Mar 1, 2024

Choose a reason for hiding this comment

csviri Mar 4, 2024

Choose a reason for hiding this comment

csviri Mar 4, 2024

Choose a reason for hiding this comment

metacosm Mar 1, 2024

Choose a reason for hiding this comment

csviri Mar 4, 2024

Choose a reason for hiding this comment

metacosm commented Mar 1, 2024

csviri commented Mar 1, 2024 • edited Loading

metacosm left a comment

Choose a reason for hiding this comment

csviri commented Mar 1, 2024 •

edited

Loading