-
Notifications
You must be signed in to change notification settings - Fork 218
Make @GradualRetry inherited #2091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Sure, feel free to add a PR! thank you! |
I just went through all the annotations in the framework to see if others might benefit from this too.
Will do a PR this weekend |
BramMeerten
pushed a commit
to BramMeerten/java-operator-sdk
that referenced
this issue
Oct 13, 2023
BramMeerten
pushed a commit
to BramMeerten/java-operator-sdk
that referenced
this issue
Oct 13, 2023
BramMeerten
pushed a commit
to BramMeerten/java-operator-sdk
that referenced
this issue
Oct 15, 2023
…rator-framework#2091) Signed-off-by: Bram Meerten <[email protected]>
BramMeerten
pushed a commit
to BramMeerten/java-operator-sdk
that referenced
this issue
Oct 15, 2023
…rator-framework#2091) Signed-off-by: Bram Meerten <[email protected]>
BramMeerten
added a commit
to BramMeerten/java-operator-sdk
that referenced
this issue
Oct 15, 2023
…rator-framework#2091) Signed-off-by: Bram Meerten <[email protected]>
BramMeerten
added a commit
to BramMeerten/java-operator-sdk
that referenced
this issue
Oct 17, 2023
…rator-framework#2091) Signed-off-by: Bram Meerten <[email protected]>
csviri
pushed a commit
to BramMeerten/java-operator-sdk
that referenced
this issue
Oct 17, 2023
…rator-framework#2091) Signed-off-by: Bram Meerten <[email protected]>
BramMeerten
added a commit
to BramMeerten/java-operator-sdk
that referenced
this issue
Oct 29, 2023
…rator-framework#2091) Signed-off-by: Bram Meerten <[email protected]>
csviri
added a commit
that referenced
this issue
Nov 13, 2023
…) (#2092) Signed-off-by: Bram Meerten <[email protected]> Co-authored-by: Attila Mészáros <[email protected]>
csviri
added a commit
that referenced
this issue
Nov 14, 2023
…) (#2092) Signed-off-by: Bram Meerten <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Signed-off-by: Attila Mészáros <[email protected]>
csviri
added a commit
that referenced
this issue
Nov 14, 2023
…) (#2092) Signed-off-by: Bram Meerten <[email protected]> Co-authored-by: Attila Mészáros <[email protected]>
csviri
added a commit
that referenced
this issue
Nov 20, 2023
…) (#2092) Signed-off-by: Bram Meerten <[email protected]> Co-authored-by: Attila Mészáros <[email protected]>
csviri
added a commit
that referenced
this issue
Nov 20, 2023
…) (#2092) Signed-off-by: Bram Meerten <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Signed-off-by: Attila Mészáros <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When a reconciler has the
@GradualRetry
annotation on a superclass, it will not be used:https://github.com/operator-framework/java-operator-sdk/blob/main/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/BaseConfigurationService.java#L280
Solution is to add @inherited to @GradualRetry
I'd be willing to contribute this change if this is an acceptable enhancement. I did a similar change in the past: #1347
Reason why this is needed in my case
I'm using micronaut framework. And when I inject my reconciler, I actually inject a proxy class that is a subclass of my Reconciler implementation (because I'm using micronaut AOP)..
The text was updated successfully, but these errors were encountered: