Skip to content

Improve WorkflowBuilder API #2284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
metacosm opened this issue Mar 12, 2024 · 1 comment · Fixed by #2511
Closed

Improve WorkflowBuilder API #2284

metacosm opened this issue Mar 12, 2024 · 1 comment · Fixed by #2511
Assignees
@metacosm
Milestone
5.0

Comments

@metacosm
Copy link
Collaborator

We should have an intermediate API to configure nodes in the workflow in a type-safe and less confusing way. Right now, things are implicitly done, relying on the order of method calls. While what is going on can easily be figured out by looking at the builder's implementation, we should make things type-safe and error-proof via the API.
@metacosm metacosm added this to the 5.0 milestone Mar 12, 2024
@csviri
Copy link
Collaborator

csviri commented Mar 12, 2024 •
edited
Loading

see also: #2256 (comment)

@metacosm metacosm self-assigned this May 28, 2024
metacosm added a commit that referenced this issue Aug 21, 2024
@metacosm
feat: explicit node configuration in WorkflowBuilder
90e3208 
Fixes #2284

Signed-off-by: Chris Laprun <[email protected]>
@metacosm metacosm mentioned this issue Aug 21, 2024
Merged
metacosm added a commit that referenced this issue Aug 30, 2024
@metacosm
feat: explicit node configuration in WorkflowBuilder
02c16ee 
Fixes #2284

Signed-off-by: Chris Laprun <[email protected]>
@metacosm metacosm linked a pull request Sep 4, 2024 that will close this issue
feat: explicit node configuration in WorkflowBuilder #2511
Merged
metacosm added a commit that referenced this issue Sep 19, 2024
@metacosm
feat: explicit node configuration in WorkflowBuilder (#2511)
706aef2 
* feat: explicit node configuration in WorkflowBuilder

Fixes #2284

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename more appropriately

Signed-off-by: Chris Laprun <[email protected]>

---------

Signed-off-by: Chris Laprun <[email protected]>
csviri pushed a commit that referenced this issue Sep 20, 2024
@metacosm @csviri
feat: explicit node configuration in WorkflowBuilder (#2511)
80842fd 
* feat: explicit node configuration in WorkflowBuilder

Fixes #2284

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename more appropriately

Signed-off-by: Chris Laprun <[email protected]>

---------

Signed-off-by: Chris Laprun <[email protected]>
@csviri csviri closed this as completed Sep 27, 2024
metacosm added a commit that referenced this issue Oct 10, 2024
@metacosm
feat: explicit node configuration in WorkflowBuilder (#2511)
b407174 
* feat: explicit node configuration in WorkflowBuilder

Fixes #2284

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename more appropriately

Signed-off-by: Chris Laprun <[email protected]>

---------

Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this issue Nov 5, 2024
@metacosm
feat: explicit node configuration in WorkflowBuilder (#2511)
bafbe09 
* feat: explicit node configuration in WorkflowBuilder

Fixes #2284

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename more appropriately

Signed-off-by: Chris Laprun <[email protected]>

---------

Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this issue Nov 6, 2024
@metacosm
feat: explicit node configuration in WorkflowBuilder (#2511)
a8d71f4 
* feat: explicit node configuration in WorkflowBuilder

Fixes #2284

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename more appropriately

Signed-off-by: Chris Laprun <[email protected]>

---------

Signed-off-by: Chris Laprun <[email protected]>
csviri pushed a commit that referenced this issue Nov 13, 2024
@metacosm @csviri
feat: explicit node configuration in WorkflowBuilder (#2511)
f2311b5 
* feat: explicit node configuration in WorkflowBuilder

Fixes #2284

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename more appropriately

Signed-off-by: Chris Laprun <[email protected]>

---------

Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this issue Nov 19, 2024
@metacosm
feat: explicit node configuration in WorkflowBuilder (#2511)
7bdd24b 
* feat: explicit node configuration in WorkflowBuilder

Fixes #2284

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename more appropriately

Signed-off-by: Chris Laprun <[email protected]>

---------

Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this issue Nov 20, 2024
@metacosm
feat: explicit node configuration in WorkflowBuilder (#2511)
028fb3a 
* feat: explicit node configuration in WorkflowBuilder

Fixes #2284

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename more appropriately

Signed-off-by: Chris Laprun <[email protected]>

---------

Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this issue Nov 27, 2024
@metacosm
feat: explicit node configuration in WorkflowBuilder (#2511)
9b15839 
* feat: explicit node configuration in WorkflowBuilder

Fixes #2284

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename more appropriately

Signed-off-by: Chris Laprun <[email protected]>

---------

Signed-off-by: Chris Laprun <[email protected]>
csviri pushed a commit that referenced this issue Dec 6, 2024
@metacosm @csviri
feat: explicit node configuration in WorkflowBuilder (#2511)
f7767c0 
* feat: explicit node configuration in WorkflowBuilder

Fixes #2284

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename more appropriately

Signed-off-by: Chris Laprun <[email protected]>

---------

Signed-off-by: Chris Laprun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metacosm metacosm

Labels
None yet
Projects
None yet
Milestone
5.0
Development

Successfully merging a pull request may close this issue.

feat: explicit node configuration in WorkflowBuilder operator-framework/java-operator-sdk
2 participants
@metacosm @csviri