Skip to content

Using only one instance of ScheduledExecutorService #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
csviri opened this issue Sep 16, 2021 · 2 comments · Fixed by #546
Closed

Using only one instance of ScheduledExecutorService #540

csviri opened this issue Sep 16, 2021 · 2 comments · Fixed by #546
Assignees
@metacosm
Labels
core java Pull requests that update Java code kind/feature Categorizes issue or PR as related to a new feature.

Comments

@csviri
Copy link
Collaborator

csviri commented Sep 16, 2021

Currently we are using ScheduledThreadPoolExecutor per controller. It would be better to control threading and related configurations if it would be shared between controllers. So there are no more such services created.
@csviri
Copy link
Collaborator Author

csviri commented Sep 16, 2021

see also: #533

@csviri csviri assigned csviri and unassigned csviri Sep 16, 2021
@csviri csviri added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 16, 2021
@jmrodri jmrodri added core java Pull requests that update Java code labels Sep 16, 2021
@lburgazzoli
Copy link
Collaborator

eventually the executor service can also been injected i.e. it can use the same thread pool as quarkus

metacosm added a commit that referenced this issue Sep 17, 2021
@metacosm
feat: use only one, configurable ExecutorService
b88a14d 
Fixes #540
@metacosm metacosm mentioned this issue Sep 17, 2021
Merged
@metacosm metacosm self-assigned this Sep 17, 2021
@snowdrop-bot snowdrop-bot mentioned this issue Sep 17, 2021
Closed
metacosm added a commit that referenced this issue Sep 21, 2021
@metacosm
feat: use only one, configurable ExecutorService
8eb6171 
Fixes #540
metacosm added a commit that referenced this issue Sep 21, 2021
@metacosm
feat: use only one, configurable ExecutorService
8394f2d 
Fixes #540
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metacosm metacosm

Labels
core java Pull requests that update Java code kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use only one, configurable ExecutorService operator-framework/java-operator-sdk
4 participants
@jmrodri @metacosm @lburgazzoli @csviri