Skip to content

Make it easier to override default ConfigurationService values #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
metacosm opened this issue Sep 16, 2021 · 2 comments · Fixed by #543
Closed

Make it easier to override default ConfigurationService values #542

metacosm opened this issue Sep 16, 2021 · 2 comments · Fixed by #543
Assignees
Labels
java Pull requests that update Java code kind/feature Categorizes issue or PR as related to a new feature.

Comments

@metacosm
Copy link
Collaborator

We should be providing a ConfigurationServiceOverrider similar to what we already do for ControllerConfiguration.

@csviri
Copy link
Collaborator

csviri commented Sep 16, 2021

Just a question, is there a partical reason why the configuration isn't an ordinary POJO?
If I remember it correctly the reason to do it in the current way was related to qarkus. Cannot be the tranlation between the service and POJO done on quarkus side?

@metacosm
Copy link
Collaborator Author

Well, there is a POJO: DefaultConfigurationService but we don't want to be using that implementation in the Quarkus extension. That implementation actually generates controllers' configuration on the fly from the controller's class annotations if it's not found in the service already and that's not a behavior we want in the Quarkus extension, which is why we have an interface. Spring Boot also uses its own implementation based on AbstractConfigurationService.

@jmrodri jmrodri added kind/feature Categorizes issue or PR as related to a new feature. java Pull requests that update Java code labels Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants