Skip to content

Misleading MissingCRDException exception #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lburgazzoli opened this issue Sep 22, 2021 · 0 comments · Fixed by #558
Closed

Misleading MissingCRDException exception #552

lburgazzoli opened this issue Sep 22, 2021 · 0 comments · Fixed by #558

Comments

@lburgazzoli
Copy link
Collaborator

lburgazzoli commented Sep 22, 2021 •
edited
Loading

If an event source fails to start and the error code is 404, the DefaultEventSourceManager wraps it with a MissingCRDException [1] which the ConfiguredController re-wrap and include details about the CRD of the controller resulting in a misleading message as the exception will report that the CRD of the controller is missing but it may not be the case.

[1] https://github.com/java-operator-sdk/java-operator-sdk/blob/master/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/DefaultEventSourceManager.java#L92-L97
[2] https://github.com/java-operator-sdk/java-operator-sdk/blob/master/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/ConfiguredController.java#L177-L182
lburgazzoli added a commit to lburgazzoli/java-operator-sdk that referenced this issue Sep 22, 2021
@lburgazzoli
fix: misleading MissingCRDException exception operator-framework#552
c752ff8
@lburgazzoli lburgazzoli mentioned this issue Sep 22, 2021
Closed
lburgazzoli added a commit to lburgazzoli/java-operator-sdk that referenced this issue Sep 22, 2021
@lburgazzoli
fix: misleading MissingCRDException exception operator-framework#552
e1fce6d
metacosm added a commit that referenced this issue Sep 23, 2021
@metacosm
fix: only throw MissingCRDException if we get a 404 on the target CRD
0b9cee8 
Note that this relies on fabric8io/kubernetes-client#3492 so won't build
until this PR is merged and available in a release.
Fixes #552
@metacosm metacosm mentioned this issue Sep 23, 2021
Merged
metacosm added a commit that referenced this issue Sep 23, 2021
@metacosm
fix: only throw MissingCRDException if we get a 404 on the target CRD
a899a4c 
Fixes #552
metacosm added a commit that referenced this issue Sep 23, 2021
@metacosm
fix: only throw MissingCRDException if we get a 404 on the target CRD
b6db6ab 
Fixes #552
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@lburgazzoli