Skip to content

Replace Closeable interface by explicit stop method on interfaces/implementations that require it #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
metacosm opened this issue Oct 27, 2021 · 1 comment
Closed

Replace Closeable interface by explicit stop method on interfaces/implementations that require it #629

metacosm opened this issue Oct 27, 2021 · 1 comment
Assignees
@metacosm
Labels
api-changes-epic kind/feature Categorizes issue or PR as related to a new feature.
Milestone
v2

Comments

@metacosm
Copy link
Collaborator

The issue is that we have an asymmetry between start and close method. We also don't leverage the try-with-resource functionality afforded by Closeable so making things explicit might be better by having an interface that would have both start & stop methods so that we have to handle that start scenario explicitly as well.
@metacosm metacosm self-assigned this Oct 27, 2021
@metacosm metacosm added kind/feature Categorizes issue or PR as related to a new feature. api-changes-epic labels Oct 27, 2021
@metacosm metacosm added this to the v2 milestone Oct 27, 2021
@snowdrop-bot snowdrop-bot mentioned this issue Oct 27, 2021
Closed
metacosm added a commit that referenced this issue Oct 27, 2021
@metacosm
refactor!: replace Closeable by explicit Stoppable interface
ad745d7 
This ensures that stoppable classes can also be started if needed.
Fixes #629
@metacosm metacosm mentioned this issue Oct 27, 2021
Merged
metacosm added a commit that referenced this issue Oct 27, 2021
@metacosm
refactor!: replace Closeable by explicit Stoppable interface
99626cb 
This ensures that stoppable classes can also be started if needed.
Fixes #629
metacosm added a commit that referenced this issue Oct 28, 2021
@metacosm
refactor!: replace Closeable by explicit Stoppable interface
d244948 
This ensures that stoppable classes can also be started if needed.
Fixes #629
metacosm added a commit that referenced this issue Oct 28, 2021
@metacosm
refactor!: replace Closeable by explicit Stoppable interface
dd050af 
This ensures that stoppable classes can also be started if needed.
Fixes #629
metacosm added a commit that referenced this issue Oct 28, 2021
@metacosm
refactor!: replace Closeable by explicit LifecycleAware interface (#633)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
cbfd993 
This ensures that stoppable classes can also be started if needed.
Fixes #629
metacosm added a commit that referenced this issue Oct 28, 2021
@metacosm
refactor!: replace Closeable by explicit Stoppable interface
d6a6d1c 
This ensures that stoppable classes can also be started if needed.
Fixes #629
@metacosm
Copy link
Collaborator Author

Fixed by #633.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metacosm metacosm

Labels
api-changes-epic kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
v2
Development

No branches or pull requests
1 participant
@metacosm