Skip to content

fix: Make @ControllerConfiguration Inherited (#1347) #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

BramMeerten
Copy link
Contributor

No description provided.

Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csviri csviri linked an issue Jul 19, 2022 that may be closed by this pull request
@BramMeerten
Copy link
Contributor Author

Is there anything at this point required from me? Or will it be merged by a maintainer?

@csviri
Copy link
Collaborator

csviri commented Jul 21, 2022

Is there anything at this point required from me? Or will it be merged by a maintainer?

No, thank you! will merge this!

@csviri csviri merged commit f43e352 into operator-framework:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make @ControllerConfiguration Inherited
3 participants