Skip to content

feat: non static reference of services #1865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 5, 2023
Merged

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Apr 20, 2023

This is a refactoring to not use static instances of certain services, thus removing ConfigurationServiceProvider, and others.

@csviri csviri self-assigned this Apr 20, 2023
@csviri csviri marked this pull request as ready for review April 25, 2023 08:15
@csviri csviri requested a review from metacosm April 25, 2023 08:15
@csviri csviri linked an issue Apr 25, 2023 that may be closed by this pull request
@csviri csviri force-pushed the non-static-conf-service branch from 59f030f to 3785ea1 Compare May 3, 2023 08:27
@csviri csviri force-pushed the next branch 3 times, most recently from e586e78 to 81b756d Compare May 4, 2023 13:18
@csviri csviri force-pushed the non-static-conf-service branch from be67e11 to 6c884a8 Compare May 5, 2023 07:19
csviri added 2 commits May 5, 2023 09:28
author csviri <[email protected]> 1681383534 +0200
committer csviri <[email protected]> 1683271037 +0200
gpgsig -----BEGIN PGP SIGNATURE-----

 iQIzBAABCgAdFiEEx4CKPTleRaFiFbIenxwva5o3BHIFAmRUrX0ACgkQnxwva5o3
 BHK1Jw/+PNwivEbJp3+A/F5rJeMBFsgPayBZAxuVqAlqd5U9uo5JlLkGddpMBf9q
 tFJyXaw/gYTO3B6XIEi8qg75l3hPJxo9rPauDT+s1t+zWpuQqrvpAatMi2cBeoaa
 Aluw2LYaKX75IEUW14ooGPwjzjnaOFs0rVPcBUgWnmQqPDFez/QC2Xz3rfGXhU2b
 P87fi/A5lZbXDXHaaWzWfJ4XoGMG4152KIo6EgM5QQGd+BD+qYm9qTATM3vVxjkQ
 PG9By9CC8u24mDVtYI9YAGLNINLk1poTC1/reVzn8cX2lVENLRWPB/mF2qc/2edu
 Z5LYkJ/7fp6qv4SS03QUC2WGycVXf9cLM/SHJiX7s87glE/rBocRVBHA1iBNbz2A
 AaiacSyQkkMdBbiVWfG7Xd//gPhAFqwFSpp6myWaqcsLEWhJ6F8J6uDTT1qjbF9W
 XviGSXugs/8U4BTpPTnh71w553/StnHHw24g9jnOGnpyPGvC5uqrDgyL4cgO4RfK
 lYvUy1APi/GAMEr7iCLXP19CFuT/QhnRzcyzU6hEFk9Pz/l2U2HHwvct7c+Snx/f
 jZ2bxVOZuZMz26w+lvlmhrZWmOdRM0CQYd6/0CzyLuTZ24LgBqlujfqYC0J9zTrZ
 NtUTT7Up6cymBbqpwyrbITEdM+3o+EmKccXwF4Qrpl/Zj0MaJCM=
 =c5ON
 -----END PGP SIGNATURE-----

chore: update version to 4.4.0-SNAPSHOT

fix: bom version

improve: configuration service no static access

wip

compiles

wip

unit tests passing

IT fixes

Fixes

comment

improvements

fix workflow execution issue

leader election fix

rebase next, test fix

improve: jetty log level to info (#1882)

chore: update version to 4.4.0-SNAPSHOT

fix: bom version

fix: avoid potential NPE

refactor: rename more appropriately

refactor: access configuration service from Operator when possible

fix: now outdated method reference

fix: format

fix: workflows don't need to record the configuration service

improve: dependent resource matcher API and handling (#1881)

refactor: get ExecutorServiceManager from ConfigurationService

feat: re-add parameter-less getEffectiveNamespaces method
@csviri csviri force-pushed the non-static-conf-service branch from 6c884a8 to 3d8f7f3 Compare May 5, 2023 07:38
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

79.4% 79.4% Coverage
0.0% 0.0% Duplication

@metacosm metacosm merged commit f8fdb1f into next May 5, 2023
@metacosm metacosm deleted the non-static-conf-service branch May 5, 2023 15:14
csviri added a commit that referenced this pull request May 24, 2023
csviri added a commit that referenced this pull request May 30, 2023
csviri added a commit that referenced this pull request May 31, 2023
csviri added a commit that referenced this pull request Jun 8, 2023
csviri added a commit that referenced this pull request Jun 16, 2023
csviri added a commit that referenced this pull request Jun 20, 2023
csviri added a commit that referenced this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make ConfigurationService accessible in a non-static way
2 participants