-
Notifications
You must be signed in to change notification settings - Fork 218
feat: non static reference of services #1865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59f030f
to
3785ea1
Compare
e586e78
to
81b756d
Compare
be67e11
to
6c884a8
Compare
author csviri <[email protected]> 1681383534 +0200 committer csviri <[email protected]> 1683271037 +0200 gpgsig -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEx4CKPTleRaFiFbIenxwva5o3BHIFAmRUrX0ACgkQnxwva5o3 BHK1Jw/+PNwivEbJp3+A/F5rJeMBFsgPayBZAxuVqAlqd5U9uo5JlLkGddpMBf9q tFJyXaw/gYTO3B6XIEi8qg75l3hPJxo9rPauDT+s1t+zWpuQqrvpAatMi2cBeoaa Aluw2LYaKX75IEUW14ooGPwjzjnaOFs0rVPcBUgWnmQqPDFez/QC2Xz3rfGXhU2b P87fi/A5lZbXDXHaaWzWfJ4XoGMG4152KIo6EgM5QQGd+BD+qYm9qTATM3vVxjkQ PG9By9CC8u24mDVtYI9YAGLNINLk1poTC1/reVzn8cX2lVENLRWPB/mF2qc/2edu Z5LYkJ/7fp6qv4SS03QUC2WGycVXf9cLM/SHJiX7s87glE/rBocRVBHA1iBNbz2A AaiacSyQkkMdBbiVWfG7Xd//gPhAFqwFSpp6myWaqcsLEWhJ6F8J6uDTT1qjbF9W XviGSXugs/8U4BTpPTnh71w553/StnHHw24g9jnOGnpyPGvC5uqrDgyL4cgO4RfK lYvUy1APi/GAMEr7iCLXP19CFuT/QhnRzcyzU6hEFk9Pz/l2U2HHwvct7c+Snx/f jZ2bxVOZuZMz26w+lvlmhrZWmOdRM0CQYd6/0CzyLuTZ24LgBqlujfqYC0J9zTrZ NtUTT7Up6cymBbqpwyrbITEdM+3o+EmKccXwF4Qrpl/Zj0MaJCM= =c5ON -----END PGP SIGNATURE----- chore: update version to 4.4.0-SNAPSHOT fix: bom version improve: configuration service no static access wip compiles wip unit tests passing IT fixes Fixes comment improvements fix workflow execution issue leader election fix rebase next, test fix improve: jetty log level to info (#1882) chore: update version to 4.4.0-SNAPSHOT fix: bom version fix: avoid potential NPE refactor: rename more appropriately refactor: access configuration service from Operator when possible fix: now outdated method reference fix: format fix: workflows don't need to record the configuration service improve: dependent resource matcher API and handling (#1881) refactor: get ExecutorServiceManager from ConfigurationService feat: re-add parameter-less getEffectiveNamespaces method
6c884a8
to
3d8f7f3
Compare
Kudos, SonarCloud Quality Gate passed! |
metacosm
approved these changes
May 5, 2023
csviri
added a commit
that referenced
this pull request
May 24, 2023
csviri
added a commit
that referenced
this pull request
May 30, 2023
csviri
added a commit
that referenced
this pull request
May 31, 2023
csviri
added a commit
that referenced
this pull request
Jun 8, 2023
csviri
added a commit
that referenced
this pull request
Jun 16, 2023
csviri
added a commit
that referenced
this pull request
Jun 20, 2023
csviri
added a commit
that referenced
this pull request
Jun 21, 2023
metacosm
pushed a commit
that referenced
this pull request
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring to not use static instances of certain services, thus removing
ConfigurationServiceProvider
, and others.