Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: same short name for multi version crd #1920

Merged
merged 3 commits into from
May 29, 2023
Merged

fix: same short name for multi version crd #1920

merged 3 commits into from
May 29, 2023
+7 −3

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented May 29, 2023

No description provided.

@csviri
fix: same shortn name for multi version crd

Verified

This commit was signed with the committer’s verified signature. The key has expired.
csviri Attila Mészáros
GPG key ID: 9F1C2F6B9A370472
Expired
Verified
Learn about vigilant mode
a469570
@csviri csviri self-assigned this May 29, 2023
csviri added 2 commits May 29, 2023 11:28
@csviri
logging crd in IT

Verified

This commit was signed with the committer’s verified signature. The key has expired.
csviri Attila Mészáros
GPG key ID: 9F1C2F6B9A370472
Expired
Verified
Learn about vigilant mode
f6faac3
@csviri
format

Verified

This commit was signed with the committer’s verified signature. The key has expired.
csviri Attila Mészáros
GPG key ID: 9F1C2F6B9A370472
Expired
Verified
Learn about vigilant mode
b808348
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

andreaTP
andreaTP approved these changes May 29, 2023
View reviewed changes
Copy link
Collaborator

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, probably we should make even the CRD generator a little more robust and throw an exception if misalignment is detected.

@csviri csviri merged commit 3280f69 into main May 29, 2023
@csviri csviri deleted the same-multi-version-crd-short branch May 29, 2023 10:51
@csviri csviri linked an issue May 29, 2023 that may be closed by this pull request
Integration Test CRD Apply Issue #1919
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaTP andreaTP

Assignees

@csviri csviri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration Test CRD Apply Issue
2 participants
@csviri @andreaTP