Skip to content

docs: fix small typos #1974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/documentation/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ following code style schemes based on the IDE you use:

## Thanks

These guidelines were best on several sources, including
These guidelines were based on several sources, including
[Atom](https://github.com/atom/atom/blob/master/CONTRIBUTING.md), [PurpleBooth's
advice](https://gist.github.com/PurpleBooth/b24679402957c63ec426) and the [Contributor
Covenant](https://www.contributor-covenant.org/).
2 changes: 1 addition & 1 deletion docs/documentation/features.md
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ object. Of note, particularly interesting is the `isLastAttempt` method, which c
in your resource' status, for example, when attempting a last retry.

Note, though, that reaching the retry limit won't prevent new events to be processed. New
reconciliations will happen for new events as usual. However, if an error also ocurrs that
reconciliations will happen for new events as usual. However, if an error also occurs that
would normally trigger a retry, the SDK won't schedule one at this point since the retry limit
is already reached.

Expand Down
2 changes: 1 addition & 1 deletion docs/documentation/workflows.md
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ stateDiagram-v2
- Root nodes (i.e. nodes that don't depend on any others) are reconciled first. In this example,
DR `1` is reconciled first since it doesn't depend on others.
After that both DR `2` and `3` are reconciled concurrently, then DR `4` once both are
reconciled sucessfully.
reconciled successfully.
- If DR `2` had a ready condition and if it evaluated to as `false`, DR `4` would not be reconciled.
However `1`,`2` and `3` would be.
- If `1` had a `false` ready condition, neither `2`,`3` or `4` would be reconciled.
Expand Down