feat: Allow configuration of informer pagination through list limit (… #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csviri
requested changes
Jul 25, 2023
| * The maximum amount of items to return for a single list call when starting an informer. If this | ||
| * is a not null it will result in paginating for the initial load of the informer cache. | ||
| */ | ||
| default Long getInformerLimit() { |
There was a problem hiding this comment.
Thinking if we could not find a more specific name. Like getInformerListLimit ? What do you think?
There was a problem hiding this comment.
I updated with your naming selection and added a link to the underlying method that ends up getting since the javadoc there has more info.
csviri
reviewed
Jul 25, 2023
| * The maximum amount of items to return for a single list call when starting an informer. If this | ||
| * is a not null it will result in paginating for the initial load of the informer cache. | ||
| */ | ||
| default Long getInformerLimit() { |
There was a problem hiding this comment.
Can we make this Optional? Also take it into account if not set?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…#1976).