-
Notifications
You must be signed in to change notification settings - Fork 218
Improvement/handle namespace deletion on finalizer gracefully #1988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement/handle namespace deletion on finalizer gracefully #1988
Conversation
Hi @Donnerbart , thx for the PR, pls can you run |
What does not adds up to me is, if the update failed, how the resources was deleted. In other words if removal of finalizer failed, how is the resource null, after getting it, should not be deleted. But other than that this look reasonable. |
...ore/src/main/java/io/javaoperatorsdk/operator/processing/event/ReconciliationDispatcher.java
Show resolved
Hide resolved
235907d
to
921c1e9
Compare
Yeah, I tried to reproduce this several times, but couldn't trigger this exception again. I think it might be a missing permission that's being removed by deleting the namespace, so the operator fails to remove the finalizer and then cannot retrieve the custom resource again. |
Makes, sense but in that case we should rather not retry, well not sure... this is quite a corner case. |
Probably would be good do a warning log there, if this happens. |
…be retrieved on finalizer removal retry
921c1e9
to
c461a84
Compare
I agree that this is probably a very rare corner case. I've added a warning for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Fixes #1987