improve: remove optimistic locking from update for SSA in dependent resources #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With #2012 optimistic locking is not required for either SSA or non-SSA - but it's still a good idea with non-SSA. The rationale here is that nearly all SSA reconstructive operations don't care about what others have done. Only if you want to take over management fo those changes do you need the absolute freshest state. There are other corner cases with SSA, such as needing to change a immutable field on a deployment, or trying to overwrite a non-managed change that confuses SSA, such as something modifying port protocol - but those should be addressed with workflow mechanisms and shouldn't depend on locking. At worst a SSA may temporarily fail. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.