improve: logging if no primary found for resource id #2036
Conversation
csviri
requested review from
metacosm
and removed request for
andreaTP and
adam-sandor
| @@ -146,7 +146,7 @@ private void submitReconciliationExecution(ResourceState state) { | |||
| controllerUnderExecution, | |||
| maybeLatest.isPresent()); | |||
| if (maybeLatest.isEmpty()) { | |||
| log.debug("no custom resource found in cache for resource id: {}", resourceID); | |||
| log.debug("no primary resource found in cache with resource id: {}", resourceID); | |||
There was a problem hiding this comment.
Better but still doesn't address the fact that we might get into that state because we're triggering event processing even though we don't expect a resource to even exist in the cache (like if a user sends events for resources that are not tracked by the Reconciler), i.e. the cache is an implementation detail that might be confusing, i.e. a user might then think: ok, it's not in cache, then fetch it from the server instead!
That said, it's indeed a debug level log so maybe it doesn't matter all that much.
There was a problem hiding this comment.
we don't expect a resource to even exist in the cache
Yeah, but this is not always the case, if the controller informer is lagging (reconnect issues), the resource might be actually expected, just not yet there.
it's not in cache, then fetch it from the server instead!
this is for primary, not sure if there is a place to fetch it; since the reconciler never triggered.
There was a problem hiding this comment.
But can add some comments there above the log message, to explain why this can happen.
No description provided.