refactor: remove now unneeded KubernetesClientAware #2084
Merged
+80
−355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Laprun <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
metacosm
force-pushed
the
remove-client
branch
from
f3197a3 to
b81e4f2
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
csviri
approved these changes
Oct 13, 2023
csviri
pushed a commit
that referenced
this pull request
Oct 18, 2023
* refactor: remove now unneeded KubernetesClientAware Signed-off-by: Chris Laprun <[email protected]> * chore: clean-up Signed-off-by: Chris Laprun <[email protected]> * refactor: more unneeded client recording removal Signed-off-by: Chris Laprun <[email protected]> * refactor: more unneeded client recording removal Signed-off-by: Chris Laprun <[email protected]> * fix: restore backwards compatibility Signed-off-by: Chris Laprun <[email protected]> --------- Signed-off-by: Chris Laprun <[email protected]>
metacosm
added a commit
that referenced
this pull request
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Laprun [email protected]