feat: activation condition #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
csviri
force-pushed
the
activation-condition
branch
from
a3f1994 to
22dd846
Compare
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri
force-pushed
the
activation-condition
branch
from
87e8875 to
a7a0d0a
Compare
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Attila Mészáros <[email protected]>
metacosm
requested changes
Nov 17, 2023
...ava/io/javaoperatorsdk/operator/sample/workflowactivationcondition/isOpenShiftCondition.java
Outdated
Show resolved
Hide resolved
| .build(); | ||
|
|
||
| @Test | ||
| void routeIsNotCreated() { |
There was a problem hiding this comment.
How is this checking that the Route is indeed not created?
There was a problem hiding this comment.
renamed the method since, but we can check if the actual platform not supporting routes. But as we discussed before, IMO the platform is our case is give (based on definition of E2E tests in github actions) that it is pure k8s (minikube) not openshift. But we can double check in test, so if that would change we would be notified.
[skip ci] Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
metacosm
reviewed
Nov 17, 2023
...java/io/javaoperatorsdk/operator/processing/dependent/workflow/AbstractWorkflowExecutor.java
Show resolved
Hide resolved
| .orElse(true); | ||
|
|
||
| boolean deletePostConditionMet = true; | ||
| if (Boolean.TRUE.equals(activationConditionMet)) { |
There was a problem hiding this comment.
Not sure what's going on here. Why not use isConditionMet?
There was a problem hiding this comment.
Hmm, by bad, changed it. thx!
...work-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventSourceManager.java
Show resolved
Hide resolved
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm
approved these changes
Nov 20, 2023
csviri
added a commit
that referenced
this pull request
Nov 20, 2023
Signed-off-by: Attila Mészáros <[email protected]>
csviri
added a commit
that referenced
this pull request
Nov 20, 2023
Signed-off-by: Attila Mészáros <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.