Update package name #220
Update package name #220
Conversation
| @@ -48,13 +47,13 @@ public void manyResourcesGetCreatedUpdatedAndDeleted() { | |||
| log.info("Creating {} new resources", NUMBER_OF_RESOURCES_CREATED); | |||
| for (int i = 0; i < NUMBER_OF_RESOURCES_CREATED; i++) { | |||
| TestCustomResource tcr = integrationTest.createTestCustomResource(String.valueOf(i)); | |||
| integrationTest.getCrOperations().inNamespace(TEST_NAMESPACE).create(tcr); | |||
There was a problem hiding this comment.
This files consist undesired changes related to auto refactoring code using IDEA, but it looks good.
| @@ -38,7 +37,7 @@ public void configMapGetsCreatedForTestCustomResource() { | |||
| integrationTestSupport.teardownIfSuccess(() -> { | |||
| TestCustomResource resource = testCustomResource(); | |||
|
|
|||
| integrationTestSupport.getCrOperations().inNamespace(TEST_NAMESPACE).create(resource); | |||
There was a problem hiding this comment.
This files consist undesired changes related to auto refactoring code using IDEA, but it looks good.
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
|
|
||
| class ControllerUtilsTest { | ||
|
|
||
| @Test | ||
| public void returnsValuesFromControllerAnnotationFinalizer() { | ||
| assertEquals(DEFAULT_FINALIZER, ControllerUtils.getDefaultFinalizer(new TestCustomResourceController(null))); |
There was a problem hiding this comment.
This files consist undesired changes related to auto refactoring code using IDEA, but it looks good.
| @@ -20,13 +18,13 @@ public void delayIsMultipliedEveryNextDelayCall() { | |||
| RetryExecution retryExecution = getDefaultRetryExecution(); | |||
|
|
|||
| Optional<Long> res = callNextDelayNTimes(retryExecution, 2); | |||
| assertThat(res.get()).isEqualTo(DEFAULT_INITIAL_INTERVAL); | |||
There was a problem hiding this comment.
This files consist undesired changes related to auto refactoring code using IDEA, but it looks good.
|
@adam-sandor this won't break the release to maven central? Aren't we registered there to some package name? |
Yes that is right. There were two options to register ourselves in MC the one that looked simpler was Github. I think for the other you actually have to own the domain (but I don't really remember this). We will definitely have to redo the MC registration process. |
this change WILL BREAK pushing to maven central, but we should also update that part and start pushing to new package there. |
> This PR consist changes related to renaming package and group for code and artifacts from com.github.containersolutions to io.javaoperatorsdk. operator-framework/java-operator-sdk#220 > This release includes new package name and artifact group id https://github.com/operator-framework/java-operator-sdk/releases/tag/v1.3.0
> This PR consist changes related to renaming package and group for code and artifacts from com.github.containersolutions to io.javaoperatorsdk. operator-framework/java-operator-sdk#220 > This release includes new package name and artifact group id https://github.com/operator-framework/java-operator-sdk/releases/tag/v1.3.0
This PR consist changes related to renaming package and group for code and artifacts from
com.github.containersolutionstoio.javaoperatorsdk.Changes includes:
✔ Java source code
✔ Readme file
✔ Maven configuration files
✔ Manifest files
✔ Site files