-
Notifications
You must be signed in to change notification settings - Fork 217
refactor: clean up ResourceConfiguration & rename to Informable #2486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Fixes #2424. --------- Signed-off-by: Attila Mészáros <[email protected]> Signed-off-by: Chris Laprun <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Signed-off-by: Chris Laprun <[email protected]>
… based on type (#2483) * refactor: integration tests moved to feature packages and sub packages pased on type Signed-off-by: Attila Mészáros <[email protected]> * fix resource paths Signed-off-by: Attila Mészáros <[email protected]> * fixes Signed-off-by: Attila Mészáros <[email protected]> * link and test fixes Signed-off-by: Attila Mészáros <[email protected]> * format Signed-off-by: Attila Mészáros <[email protected]> * wip Signed-off-by: Attila Mészáros <[email protected]> * old service Signed-off-by: Attila Mészáros <[email protected]> * test fix Signed-off-by: Attila Mészáros <[email protected]> * refactor: remove unneeded classes Signed-off-by: Chris Laprun <[email protected]> * fix: typo in package name Signed-off-by: Chris Laprun <[email protected]> --------- Signed-off-by: Attila Mészáros <[email protected]> Signed-off-by: Chris Laprun <[email protected]> Co-authored-by: Chris Laprun <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
8c4fd8d
to
724008a
Compare
csviri
requested changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me, just added some minor comments questoins.
...r-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/DefaultInformable.java
Outdated
Show resolved
Hide resolved
...ramework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationService.java
Outdated
Show resolved
Hide resolved
...n/java/io/javaoperatorsdk/operator/api/config/informer/InformerEventSourceConfiguration.java
Show resolved
Hide resolved
...r-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/DefaultInformable.java
Outdated
Show resolved
Hide resolved
...io/javaoperatorsdk/operator/processing/event/source/informer/ManagedInformerEventSource.java
Show resolved
Hide resolved
...ore/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerConfiguration.java
Show resolved
Hide resolved
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
csviri
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great , LGTM!
metacosm
added a commit
that referenced
this pull request
Aug 29, 2024
--------- Signed-off-by: Attila Mészáros <[email protected]> Signed-off-by: Chris Laprun <[email protected]> Signed-off-by: Attila Mészáros <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Co-authored-by: Attila Mészáros <[email protected]>
csviri
added a commit
that referenced
this pull request
Sep 20, 2024
--------- Signed-off-by: Attila Mészáros <[email protected]> Signed-off-by: Chris Laprun <[email protected]> Signed-off-by: Attila Mészáros <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Co-authored-by: Attila Mészáros <[email protected]>
metacosm
added a commit
that referenced
this pull request
Oct 10, 2024
--------- Signed-off-by: Attila Mészáros <[email protected]> Signed-off-by: Chris Laprun <[email protected]> Signed-off-by: Attila Mészáros <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Co-authored-by: Attila Mészáros <[email protected]>
metacosm
added a commit
that referenced
this pull request
Nov 5, 2024
--------- Signed-off-by: Attila Mészáros <[email protected]> Signed-off-by: Chris Laprun <[email protected]> Signed-off-by: Attila Mészáros <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Co-authored-by: Attila Mészáros <[email protected]>
metacosm
added a commit
that referenced
this pull request
Nov 6, 2024
--------- Signed-off-by: Attila Mészáros <[email protected]> Signed-off-by: Chris Laprun <[email protected]> Signed-off-by: Attila Mészáros <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Co-authored-by: Attila Mészáros <[email protected]>
csviri
added a commit
that referenced
this pull request
Nov 13, 2024
--------- Signed-off-by: Attila Mészáros <[email protected]> Signed-off-by: Chris Laprun <[email protected]> Signed-off-by: Attila Mészáros <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Co-authored-by: Attila Mészáros <[email protected]>
metacosm
added a commit
that referenced
this pull request
Nov 19, 2024
--------- Signed-off-by: Attila Mészáros <[email protected]> Signed-off-by: Chris Laprun <[email protected]> Signed-off-by: Attila Mészáros <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Co-authored-by: Attila Mészáros <[email protected]>
metacosm
added a commit
that referenced
this pull request
Nov 20, 2024
--------- Signed-off-by: Attila Mészáros <[email protected]> Signed-off-by: Chris Laprun <[email protected]> Signed-off-by: Attila Mészáros <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Co-authored-by: Attila Mészáros <[email protected]>
metacosm
added a commit
that referenced
this pull request
Nov 27, 2024
--------- Signed-off-by: Attila Mészáros <[email protected]> Signed-off-by: Chris Laprun <[email protected]> Signed-off-by: Attila Mészáros <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Co-authored-by: Attila Mészáros <[email protected]>
This was referenced Dec 3, 2024
csviri
added a commit
that referenced
this pull request
Dec 6, 2024
--------- Signed-off-by: Attila Mészáros <[email protected]> Signed-off-by: Chris Laprun <[email protected]> Signed-off-by: Attila Mészáros <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Co-authored-by: Attila Mészáros <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Laprun [email protected]