refactor: make shouldUseSSA work with types instead of instances + tests #2538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Laprun <[email protected]>
xstefank
approved these changes
Sep 24, 2024
| * @return {@code true} if SSA should be used for | ||
| * @param <R> the dependent resource type | ||
| * @param <P> the primary resource type | ||
| * @since 4.9.4 |
There was a problem hiding this comment.
I personally don't think that deprecating should mean removing of old JavaDoc but I don't know what's the custom in this project.
There was a problem hiding this comment.
I don't think we have one but removing the javadoc makes it even more obvious that people should really be using the other one instead, imo… 😅
There was a problem hiding this comment.
I've removed the deprecation in the end.
Signed-off-by: Chris Laprun <[email protected]>
csviri
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Laprun [email protected]