docs: withKubernetesClient improved docs #2564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Attila Mészáros <[email protected]>
metacosm
requested changes
Oct 28, 2024
| @@ -121,6 +122,10 @@ public ConfigurationServiceOverrider withWorkflowExecutorService( | |||
| /** | |||
| * Replaces the default {@link KubernetesClient} instance by the specified one. This is the | |||
| * preferred mechanism to configure which client will be used to access the cluster. | |||
| * <p> | |||
| * Note that when {@link Operator#stop()} is called, by default the client is closed even if | |||
| * explicitly provided with this method. Use {@link #withKubernetesClient(KubernetesClient)} to | |||
There was a problem hiding this comment.
This isn't the correct link to the method to use
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.