feat: return result when calling workflow explicitly #2601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Laprun <[email protected]>
xstefank
reviewed
Nov 22, 2024
|
|
||
| import io.javaoperatorsdk.operator.api.reconciler.dependent.DependentResource; | ||
|
|
||
| @SuppressWarnings("rawtypes") | ||
| public class WorkflowCleanupResult extends WorkflowResult { | ||
| private Boolean allPostConditionsMet; | ||
| public interface WorkflowCleanupResult extends WorkflowResult { |
There was a problem hiding this comment.
Can this kind of change go in not a major release? This is a public class so it will break user code if someone extended it originally and now it's an interface.
There was a problem hiding this comment.
Theoretically, yes. Practically, these classes are not meant to be extended by the user, they're objects that the SDK returns as part of its processing. The only case where I could potentially imagine a user extending these classes would be in tests but even so, that would be quite a stretch, in my opinion…
There was a problem hiding this comment.
This targets next, what will be a major release.
There was a problem hiding this comment.
Also, yes! Forgot about that! 🤦😅
| import java.util.Optional; | ||
|
|
||
| import io.javaoperatorsdk.operator.api.reconciler.dependent.DependentResource; | ||
|
|
||
| @SuppressWarnings("rawtypes") | ||
| public class WorkflowReconcileResult extends WorkflowResult { | ||
| public interface WorkflowReconcileResult extends WorkflowResult { |
csviri
approved these changes
Nov 22, 2024
metacosm
added a commit
that referenced
this pull request
Nov 27, 2024
Signed-off-by: Chris Laprun <[email protected]>
This was referenced Dec 3, 2024
csviri
pushed a commit
that referenced
this pull request
Dec 6, 2024
Signed-off-by: Chris Laprun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Laprun [email protected]