Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: v5.0.0 related fixes from beta feedback #2638

Merged
merged 1 commit into from
Dec 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/content/en/blog/releases/v5-release.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ Such an informer behaves exactly as a regular one. Owner references won't work i
specify a `SecondaryToPrimaryMapper` (probably based on labels or annotations).

See related integration
test [here](https://github.com/operator-framework/java-operator-sdk/tree/1635c9ea338f8e89bacc547808d2b409de8734cf/operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerremotecluster)
test [here](https://github.com/operator-framework/java-operator-sdk/tree/main/operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerremotecluster)

#### SecondaryToPrimaryMapper now checks resource types

Expand Down
4 changes: 2 additions & 2 deletions docs/content/en/docs/features/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ public class WebappReconciler
@Override
public Map<String, EventSource> prepareEventSources(EventSourceContext<Webapp> context) {
InformerConfiguration<Tomcat> configuration =
InformerConfiguration.from(Tomcat.class, context)
InformerEventSourceConfiguration.from(Tomcat.class, Tomcat.class)
.withSecondaryToPrimaryMapper(webappsMatchingTomcatName)
.withPrimaryToSecondaryMapper(
(Webapp primary) -> Set.of(new ResourceID(primary.getSpec().getTomcat(),
Expand Down Expand Up @@ -672,7 +672,7 @@ public class MyReconciler implements Reconciler<TestCustomResource> {
EventSourceContext<ChangeNamespaceTestCustomResource> context) {

InformerEventSource<ConfigMap, TestCustomResource> configMapES =
new InformerEventSource<>(InformerConfiguration.from(ConfigMap.class)
new InformerEventSource<>(InformerEventSourceConfiguration.from(ConfigMap.class, TestCustomResource.class)
.withNamespacesInheritedFromController(context)
.build(), context);

Expand Down
4 changes: 2 additions & 2 deletions docs/content/en/docs/workflows/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@ public class SampleWorkflowReconciler implements Reconciler<WorkflowAllFeatureCu

resource.getStatus()
.setReady(
context.managedDependentResourceContext() // accessing workflow reconciliation results
.getWorkflowReconcileResult().orElseThrow()
context.managedWorkflowAndDependentResourceContext() // accessing workflow reconciliation results
.getWorkflowReconcileResult()
.allDependentResourcesReady());
return UpdateControl.patchStatus(resource);
}
Expand Down