fix: explicit workflow invovation cleanup issue #2680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Attila Mészáros <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
xstefank
reviewed
Feb 4, 2025
| @@ -195,7 +195,7 @@ public DeleteControl execute() throws Exception { | |||
|
|
|||
| // The cleanup is called also when explicit invocation is true, but the cleaner is not | |||
| // implemented | |||
| if (managedWorkflow.hasCleaner() || !explicitWorkflowInvocation) { | |||
| if (managedWorkflow.hasCleaner() && !explicitWorkflowInvocation) { | |||
There was a problem hiding this comment.
TBH, I miss the context here, but if I understand the comment above correctly it should be:
Suggested change
| if (managedWorkflow.hasCleaner() && !explicitWorkflowInvocation) { | |
| if (managedWorkflow.hasCleaner() || explicitWorkflowInvocation) { |
There was a problem hiding this comment.
Updated the PR and also the comment. It's a bit more complicated than that.
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri
changed the title
Signed-off-by: Attila Mészáros <[email protected]>
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Attila Mészáros <[email protected]>
xstefank
approved these changes
Feb 5, 2025
metacosm
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Attila Mészáros [email protected]