Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dependent resource set controller flag on owner reference #2717

Draft
wants to merge 1 commit into
base: next
Choose a base branch
from
Draft

feat: dependent resource set controller flag on owner reference #2717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...main/java/io/javaoperatorsdk/operator/processing/dependent/AbstractDependentResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,4 +238,8 @@ protected boolean creatable() {
protected boolean updatable() {
return updatable;
}

protected Boolean readonly() {
return !isCreatable() && !isUpdatable() && !isDeletable();
}
}
12 changes: 11 additions & 1 deletion ...javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
import java.util.Optional;
import java.util.Set;

import io.fabric8.kubernetes.api.model.OwnerReference;
import io.fabric8.kubernetes.api.model.OwnerReferenceBuilder;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand Down Expand Up @@ -171,7 +173,15 @@ protected Resource<R> prepare(Context<P> context, R desired, P primary, String a
protected void addReferenceHandlingMetadata(R desired, P primary) {
if (addOwnerReference()) {
ReconcilerUtils.checkIfCanAddOwnerReference(primary, desired);
desired.addOwnerReference(primary);

OwnerReferenceBuilder ownerRef = new OwnerReferenceBuilder()
.withApiVersion(primary.getApiVersion())
.withKind(primary.getKind())
.withName(primary.getMetadata().getName())
.withUid(primary.getMetadata().getUid())
.withController(!readonly());

desired.addOwnerReference(ownerRef.build());
} else if (useNonOwnerRefBasedSecondaryToPrimaryMapping()) {
addSecondaryToPrimaryMapperAnnotations(desired, primary);
}
Expand Down
Loading