Skip to content

improve: remove seamless type change #2726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
public class GenericKubernetesDependentResource<P extends HasMetadata>
extends KubernetesDependentResource<GenericKubernetesResource, P> {

private final GroupVersionKindPlural groupVersionKind;
private final GroupVersionKind groupVersionKind;

public GenericKubernetesDependentResource(GroupVersionKind groupVersionKind) {
this(GroupVersionKindPlural.from(groupVersionKind));
Expand All @@ -20,14 +20,15 @@ public GenericKubernetesDependentResource(GroupVersionKindPlural groupVersionKin
this.groupVersionKind = groupVersionKind;
}

@Override
protected InformerEventSourceConfiguration.Builder<GenericKubernetesResource>
informerConfigurationBuilder(EventSourceContext<P> context) {
return InformerEventSourceConfiguration.from(
groupVersionKind, context.getPrimaryResourceClass());
}

@SuppressWarnings("unused")
public GroupVersionKindPlural getGroupVersionKind() {
public GroupVersionKind getGroupVersionKind() {
return groupVersionKind;
}
}