fix: primary cache utils mechanism #2814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Attila Mészáros <[email protected]>
|
see expalnation #2815 |
xstefank
approved these changes
May 21, 2025
...ore/src/main/java/io/javaoperatorsdk/operator/api/reconciler/PrimaryUpdateAndCacheUtils.java
Show resolved
Hide resolved
Signed-off-by: Attila Mészáros <[email protected]>
csviri
commented
May 22, 2025
| @@ -25,6 +27,8 @@ | |||
| public class PrimaryUpdateAndCacheUtils { | |||
|
|
|||
| public static final int DEFAULT_MAX_RETRY = 10; | |||
| public static final int RESOURCE_CACHE_POLL_TIMEOUT = 10000; | |||
There was a problem hiding this comment.
@shawkins do you know some real life data, if on how long it would take on larger cluster to an informer to receive the event? On small one is almost instant (if watch works), not sure how the cluster size influences this.
xstefank
approved these changes
May 22, 2025
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
metacosm
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading from API server was not correct, this works in all cases only if the informer cache has the up to date resources.
If we don't have the up to date resource in the cache, and don't do the update based on that, we cannot say for sure if we can remove the resource for the next event or not from overlay cache.
Signed-off-by: Attila Mészáros [email protected]