Skip to content

fix: minor improvements on tests #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2021
Merged

fix: minor improvements on tests #640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...rk-core/src/test/java/io/javaoperatorsdk/operator/processing/DefaultEventHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ public void schedulesAnEventRetryOnException() {
}

@Test
public void executesTheControllerInstantlyAfterErrorIfEventsBuffered() {
public void executesTheControllerInstantlyAfterErrorIfNewEventsReceived() {
Event event = prepareCREvent();
TestCustomResource customResource = testCustomResource();
overrideData(event.getRelatedCustomResourceID(), customResource);
Expand All @@ -114,7 +114,7 @@ public void executesTheControllerInstantlyAfterErrorIfEventsBuffered() {

// start processing an event
defaultEventHandlerWithRetry.handleEvent(event);
// buffer another event
// handle another event
defaultEventHandlerWithRetry.handleEvent(event);

ArgumentCaptor<ExecutionScope> executionScopeArgumentCaptor =
Expand Down Expand Up @@ -180,7 +180,7 @@ public void scheduleTimedEventIfInstructedByPostExecutionControl() {
}

@Test
public void reScheduleOnlyIfNotExecutedBufferedEvents() {
public void reScheduleOnlyIfNotExecutedEventsReceivedMeanwhile() {
var testDelay = 10000L;
when(eventDispatcherMock.handleExecution(any()))
.thenReturn(PostExecutionControl.defaultDispatch().withReSchedule(testDelay));
Expand Down