Skip to content

Support Standard Kuberentes Resources not just CustomResource #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Nov 22, 2021
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
c2179ac
feat!: has metada instead of CustomResource in the core of the system
csviri Nov 12, 2021
f8dcf1f
feat: simple IT
csviri Nov 12, 2021
bfed546
fix: add config map IT
csviri Nov 12, 2021
a8d14e8
fix: formatting
csviri Nov 12, 2021
ae93774
feat!: has metada instead of CustomResource in the core of the system
csviri Nov 12, 2021
4535fc4
feat: simple IT
csviri Nov 12, 2021
6853b84
fix: add config map IT
csviri Nov 12, 2021
0b21975
fix: formatting
csviri Nov 12, 2021
e02f1be
Merge remote-tracking branch 'origin/support-non-cr' into support-non-cr
csviri Nov 17, 2021
fddedb5
fix: rebase + update
csviri Nov 17, 2021
24d6194
fix: Integration Tests
csviri Nov 17, 2021
29f53c6
fix: formatting
csviri Nov 17, 2021
cbf7a14
fix: better naming? customResource -> resource
csviri Nov 17, 2021
fafe9b0
refactor: resourcId
csviri Nov 17, 2021
71bb232
fix: formatting
csviri Nov 17, 2021
4682d92
fix: added intergation test for deployment, removed config map tests
csviri Nov 18, 2021
8f08cca
fix: format
csviri Nov 18, 2021
9189a94
fix: IT test update
csviri Nov 18, 2021
0446fd6
fix: format
csviri Nov 18, 2021
ef7f9b7
Merge branch 'v2' into support-non-cr
csviri Nov 19, 2021
3d82e02
fix: merged v2, fixes
csviri Nov 19, 2021
0fa1a5f
refactor: rename method more appropriately
metacosm Nov 19, 2021
d091e96
refactor: rename method more appropriately
metacosm Nov 19, 2021
d385a0e
chore: add todo to remind us to use HasStatus when available
metacosm Nov 19, 2021
6bba18e
chore: more renaming
metacosm Nov 19, 2021
a876548
chore: add todo to remind us to use HasStatus when available
metacosm Nov 19, 2021
fdf5bab
fix: rename
csviri Nov 22, 2021
7f23e2c
Merge branch 'support-non-cr' of github.com:java-operator-sdk/java-op…
csviri Nov 22, 2021
2a96c84
fix: test timeout
csviri Nov 22, 2021
61ee5e3
fix: naming improvements and poll interval
csviri Nov 22, 2021
29d2a14
fix: test tuning
csviri Nov 22, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,14 @@ public class KubernetesResourceStatusUpdateIT {
@Test
public void testReconciliationOfNonCustomResourceAndStatusUpdate() {
var deployment = operator.create(Deployment.class, testDeployment());
await().atMost(10, TimeUnit.SECONDS).untilAsserted(() -> {
await().atMost(15, TimeUnit.SECONDS).untilAsserted(() -> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it taking longer now, though?

Copy link
Collaborator Author

@csviri csviri Nov 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying something, just on one kubernetes version in tests sometimes fails. And it looks like for a timeout for retry after a conflict. But still working on it to figure it out

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the problem is with namespace deletion, not with the actual test logic.

var d = operator.get(Deployment.class, deployment.getMetadata().getName());
assertThat(d.getStatus()).isNotNull();
assertThat(d.getStatus().getConditions()).isNotNull();
assertThat(
d.getStatus().getConditions().stream().filter(c -> c.getMessage().equals(STATUS_MESSAGE))
.count()).isEqualTo(1);
});
System.out.println("ok");
}

private Deployment testDeployment() {
Expand Down