Skip to content

refactor: API changes of Update Control #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@ public static <T extends HasMetadata> UpdateControl<T> updateResource(T customRe
return new UpdateControl<>(customResource, false, true);
}

public static <T extends HasMetadata> UpdateControl<T> updateStatusSubResource(
public static <T extends HasMetadata> UpdateControl<T> updateStatus(
T customResource) {
return new UpdateControl<>(customResource, true, false);
}
@@ -35,7 +35,7 @@ public static <T extends HasMetadata> UpdateControl<T> updateStatusSubResource(
* @param customResource - custom resource to use in both API calls
* @return UpdateControl instance
*/
public static <T extends HasMetadata> UpdateControl<T> updateCustomResourceAndStatus(
public static <T extends HasMetadata> UpdateControl<T> updateResourceAndStatus(
T customResource) {
return new UpdateControl<>(customResource, true, true);
}
Original file line number Diff line number Diff line change
@@ -92,7 +92,7 @@ void updatesOnlyStatusSubResourceIfFinalizerSet() {
testCustomResource.addFinalizer(DEFAULT_FINALIZER);

when(reconciler.reconcile(eq(testCustomResource), any()))
.thenReturn(UpdateControl.updateStatusSubResource(testCustomResource));
.thenReturn(UpdateControl.updateStatus(testCustomResource));

reconciliationDispatcher.handleExecution(executionScopeWithCREvent(testCustomResource));

@@ -105,7 +105,7 @@ void updatesBothResourceAndStatusIfFinalizerSet() {
testCustomResource.addFinalizer(DEFAULT_FINALIZER);

when(reconciler.reconcile(eq(testCustomResource), any()))
.thenReturn(UpdateControl.updateCustomResourceAndStatus(testCustomResource));
.thenReturn(UpdateControl.updateResourceAndStatus(testCustomResource));
when(customResourceFacade.replaceWithLock(testCustomResource)).thenReturn(testCustomResource);

reconciliationDispatcher.handleExecution(executionScopeWithCREvent(testCustomResource));
@@ -281,7 +281,7 @@ void setReScheduleToPostExecutionControlFromUpdateControl() {

when(reconciler.reconcile(eq(testCustomResource), any()))
.thenReturn(
UpdateControl.updateStatusSubResource(testCustomResource).rescheduleAfter(1000L));
UpdateControl.updateStatus(testCustomResource).rescheduleAfter(1000L));

PostExecutionControl control =
reconciliationDispatcher.handleExecution(executionScopeWithCREvent(testCustomResource));
@@ -315,7 +315,7 @@ void setObservedGenerationForStatusIfNeeded() {

when(lConfiguration.isGenerationAware()).thenReturn(true);
when(lController.reconcile(eq(observedGenResource), any()))
.thenReturn(UpdateControl.updateStatusSubResource(observedGenResource));
.thenReturn(UpdateControl.updateStatus(observedGenResource));
when(lFacade.updateStatus(observedGenResource)).thenReturn(observedGenResource);

PostExecutionControl<ObservedGenCustomResource> control = lDispatcher.handleExecution(
Original file line number Diff line number Diff line change
@@ -173,7 +173,7 @@ public UpdateControl<TestCustomResource> reconcile(

consumer.accept(resource);

return UpdateControl.updateStatusSubResource(resource);
return UpdateControl.updateStatus(resource);
}
}
}
Original file line number Diff line number Diff line change
@@ -42,7 +42,7 @@ public UpdateControl<Deployment> reconcile(
if (condition.isEmpty()) {
conditions.add(new DeploymentCondition(null, null, STATUS_MESSAGE, null,
"unknown", "DeploymentReconciler"));
return UpdateControl.updateStatusSubResource(resource);
return UpdateControl.updateStatus(resource);
} else {
return UpdateControl.noUpdate();
}
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@ public UpdateControl<DoubleUpdateTestCustomResource> reconcile(
ensureStatusExists(resource);
resource.getStatus().setState(DoubleUpdateTestCustomResourceStatus.State.SUCCESS);

return UpdateControl.updateCustomResourceAndStatus(resource);
return UpdateControl.updateResourceAndStatus(resource);
}

private void ensureStatusExists(DoubleUpdateTestCustomResource resource) {
Original file line number Diff line number Diff line change
@@ -27,7 +27,7 @@ public UpdateControl<EventSourceTestCustomResource> reconcile(
ensureStatusExists(resource);
resource.getStatus().setState(EventSourceTestCustomResourceStatus.State.SUCCESS);

return UpdateControl.updateStatusSubResource(resource).rescheduleAfter(TIMER_PERIOD);
return UpdateControl.updateStatus(resource).rescheduleAfter(TIMER_PERIOD);
}

private void ensureStatusExists(EventSourceTestCustomResource resource) {
Original file line number Diff line number Diff line change
@@ -55,7 +55,7 @@ public UpdateControl<InformerEventSourceTestCustomResource> reconcile(
LOGGER.debug("Setting target status for CR: {}", targetStatus);
resource.setStatus(new InformerEventSourceTestCustomResourceStatus());
resource.getStatus().setConfigMapValue(targetStatus);
return UpdateControl.updateStatusSubResource(resource);
return UpdateControl.updateStatus(resource);
}

@Override
Original file line number Diff line number Diff line change
@@ -46,7 +46,7 @@ public UpdateControl<RetryTestCustomResource> reconcile(
ensureStatusExists(resource);
resource.getStatus().setState(RetryTestCustomResourceStatus.State.SUCCESS);

return UpdateControl.updateStatusSubResource(resource);
return UpdateControl.updateStatus(resource);
}

private void ensureStatusExists(RetryTestCustomResource resource) {
Original file line number Diff line number Diff line change
@@ -128,7 +128,7 @@ public UpdateControl<TestCustomResource> reconcile(
}
resource.getStatus().setConfigMapStatus("ConfigMap Ready");
}
return UpdateControl.updateStatusSubResource(resource);
return UpdateControl.updateStatus(resource);
}

private Map<String, String> configMapData(TestCustomResource resource) {
Original file line number Diff line number Diff line change
@@ -36,7 +36,7 @@ public UpdateControl<SubResourceTestCustomResource> reconcile(
ensureStatusExists(resource);
resource.getStatus().setState(SubResourceTestCustomResourceStatus.State.SUCCESS);

return UpdateControl.updateStatusSubResource(resource);
return UpdateControl.updateStatus(resource);
}

private void ensureStatusExists(SubResourceTestCustomResource resource) {
Original file line number Diff line number Diff line change
@@ -75,7 +75,7 @@ public UpdateControl<Tomcat> reconcile(Tomcat tomcat, Context context) {
tomcat.getMetadata().getName(),
tomcat.getMetadata().getNamespace(),
tomcat.getStatus().getReadyReplicas());
return UpdateControl.updateStatusSubResource(updatedTomcat);
return UpdateControl.updateStatus(updatedTomcat);
}
return UpdateControl.noUpdate();
}
Original file line number Diff line number Diff line change
@@ -98,7 +98,7 @@ public UpdateControl<Webapp> reconcile(Webapp webapp, Context context) {
}
webapp.getStatus().setDeployedArtifact(webapp.getSpec().getUrl());
webapp.getStatus().setDeploymentStatus(commandStatusInAllPods);
return UpdateControl.updateStatusSubResource(webapp);
return UpdateControl.updateStatus(webapp);
} else {
log.info("WebappController invoked but Tomcat not ready yet ({}/{})",
tomcat.getStatus() != null ? tomcat.getStatus().getReadyReplicas() : 0,