Skip to content

Add spring boot integration test #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

Sgitario
Copy link
Contributor

@Sgitario Sgitario commented Jul 14, 2022

Added an initial CI job to verify the steps to test the spring boot sample.
Note that there are many hardcoded values that need to be fixed in separate tests:

  • The scripts to create the webhooks have the K8s namespace "test" hardcoded.
  • The dnsNames of the spring-boot-sample contain hardcoded the K8s namespace "test". This issue will be fixed in the next version of Dekorate.
    In future iterations, we should ease this workflow by generating the webhooks manifests for example.

@Sgitario Sgitario force-pushed the ci_spring_boot_example branch 4 times, most recently from b4b8457 to c77e045 Compare July 14, 2022 13:33
@Sgitario Sgitario force-pushed the ci_spring_boot_example branch from c77e045 to 6cfd48b Compare July 14, 2022 13:55
@Sgitario Sgitario marked this pull request as ready for review July 14, 2022 14:01
@Sgitario
Copy link
Contributor Author

@csviri I only added the integration test for PR builds. Do you want it to add it into other workflows like "master-snapshot-release.yml", the "test" job?

@csviri
Copy link
Contributor

csviri commented Jul 15, 2022

@csviri I only added the integration test for PR builds. Do you want it to add it into other workflows like "master-snapshot-release.yml", the "test" job?

good, question, since they not running long, not really consuming too much resources, we might now.

@Sgitario
Copy link
Contributor Author

Sgitario commented Jul 20, 2022

@csviri I only added the integration test for PR builds. Do you want it to add it into other workflows like "master-snapshot-release.yml", the "test" job?

good, question, since they not running long, not really consuming too much resources, we might now.

Added spring boot IT as part of the release workflow @csviri

@Sgitario Sgitario force-pushed the ci_spring_boot_example branch from 17df56b to 6cfd48b Compare August 8, 2022 05:41
@Sgitario Sgitario requested a review from csviri August 8, 2022 05:41
Copy link
Contributor

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csviri csviri merged commit 38044b3 into operator-framework:main Sep 2, 2022
@Sgitario Sgitario deleted the ci_spring_boot_example branch September 2, 2022 10:50
@csviri
Copy link
Contributor

csviri commented Sep 2, 2022

thank you @Sgitario !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants