Skip to content

Add notes on deleting an operator CR #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

awgreene
Copy link
Member

This commit introduces documentation detailing how to delete an operator
CR.

Signed-off-by: Alexander Greene [email protected]

@openshift-ci openshift-ci bot requested review from dinhxuanvu and exdx August 30, 2022 21:30
@perdasilva
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2022
Comment on lines 78 to 83
1. Delete each resource found in the `operator CR's` status.Components array. Alternatively, if you have deleted the operator's CSV and Subscription, you can simply remove the `operators.coreos.com/<operator CR Name>` label.
2. Delete the `operator CR`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These bullet points don't seem to render in the deploy preview. It looks like you'd need to substitute them with the - character.

@timflannagan
Copy link
Member

LGTM outside of the rendering issues. Also: operator cr vs. operator cr for code brackets?

@awgreene awgreene force-pushed the deleting-an-operator-cr branch from 294f1c6 to a2b342c Compare August 31, 2022 17:29
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 31, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: awgreene
Once this PR has been reviewed and has the lgtm label, please ask for approval from perdasilva by writing /assign @perdasilva in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@awgreene awgreene force-pushed the deleting-an-operator-cr branch 2 times, most recently from 07ca909 to c1cb78a Compare August 31, 2022 17:31
@perdasilva
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2022
@awgreene awgreene force-pushed the deleting-an-operator-cr branch from c1cb78a to 0a3454c Compare August 31, 2022 17:41
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2022
@awgreene awgreene force-pushed the deleting-an-operator-cr branch 3 times, most recently from 0c311fa to 50790bb Compare August 31, 2022 17:46
@timflannagan
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2022
@awgreene awgreene force-pushed the deleting-an-operator-cr branch from 50790bb to 5c4ce72 Compare September 1, 2022 14:01
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2022
@timflannagan
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Sep 13, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 13, 2022

New changes are detected. LGTM label has been removed.

@awgreene awgreene force-pushed the deleting-an-operator-cr branch from 8345ecb to d57ca2a Compare September 13, 2022 20:53
@awgreene awgreene force-pushed the deleting-an-operator-cr branch from d57ca2a to 1b5a181 Compare September 13, 2022 20:54
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2024
@grokspawn grokspawn added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 11, 2024
This commit introduces documentation detailing how to delete an operator
CR.

Signed-off-by: Alexander Greene <[email protected]>
@perdasilva perdasilva force-pushed the deleting-an-operator-cr branch from 1b5a181 to 03652ae Compare November 25, 2024 09:57
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2024
@perdasilva perdasilva merged commit ab13152 into operator-framework:master Nov 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants