⚠ (catalogd) Update query endpoint to metas endpoint #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joelanford
previously approved these changes
Feb 4, 2025
The [RFC](https://docs.google.com/document/d/1s6_9IFEKGQLNh3ueH7SF4Yrx4PW9NSiNFqFIJx0pU-8/edit?usp=sharing) was updated to reflect a decision to change the new endpoint from $base/api/v1/query to $base/api/v1/metas. This PR makes that change.
anik120
force-pushed
the
update-query-meta
branch
from
0f388d2 to
2dc1fa2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1703 +/- ##
==========================================
- Coverage 67.49% 67.47% -0.02%
==========================================
Files 59 59
Lines 5003 5003
==========================================
- Hits 3377 3376 -1
- Misses 1379 1380 +1
Partials 247 247
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
grokspawn
approved these changes
Feb 4, 2025
Merged
via the queue into
operator-framework:main
with commit Feb 4, 2025
38b4795
21 of 22 checks passed
anik120
added a commit
to anik120/operator-controller
that referenced
this pull request
Feb 5, 2025
Also rename `query` to `metas` in places that were missed by operator-framework#1703 Signed-off-by: Anik Bhattacharjee <[email protected]>
4 tasks
anik120
added a commit
to anik120/operator-controller
that referenced
this pull request
Feb 5, 2025
Also rename `query` to `metas` in places that were missed by operator-framework#1703 Signed-off-by: Anik Bhattacharjee <[email protected]>
anik120
added a commit
to anik120/operator-controller
that referenced
this pull request
Feb 6, 2025
Also rename `query` to `metas` in places that were missed by operator-framework#1703 Signed-off-by: Anik Bhattacharjee <[email protected]>
12 tasks
anik120
added a commit
to anik120/operator-controller
that referenced
this pull request
Feb 6, 2025
Also rename `query` to `metas` in places that were missed by operator-framework#1703 Signed-off-by: Anik Bhattacharjee <[email protected]>
anik120
added a commit
to anik120/operator-controller
that referenced
this pull request
Feb 6, 2025
Also rename `query` to `metas` in places that were missed by operator-framework#1703 Signed-off-by: Anik Bhattacharjee <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
Also rename `query` to `metas` in places that were missed by #1703 Signed-off-by: Anik Bhattacharjee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RFC was updated to reflect a decision to change the new endpoint from $base/api/v1/query to $base/api/v1/metas.
This PR makes that change.
Description
Reviewer Checklist