-
Notifications
You must be signed in to change notification settings - Fork 62
🐛 fix: Ensure logger is initialized before logging errors #1777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix: Ensure logger is initialized before logging errors #1777
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @tmshort @joelanford |
05b62d0
to
dbd6182
Compare
@@ -136,6 +136,8 @@ func main() { | |||
os.Exit(0) | |||
} | |||
|
|||
ctrl.SetLogger(textlogger.NewLogger(textlogger.NewConfig())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just call before be used
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1777 +/- ##
==========================================
+ Coverage 68.24% 68.26% +0.01%
==========================================
Files 63 63
Lines 5121 5123 +2
==========================================
+ Hits 3495 3497 +2
Misses 1396 1396
Partials 230 230
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dbd6182
to
e240fb4
Compare
/hold Look at #1779, it does a bit more for logging initialization |
Fix scenario where setupLogger is not logging because it was not initialized.
Closes: #1556
Description
Before this PR:
After
Reviewer Checklist