Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ check if helm chart is served by registry/v1 bundle #1878

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

OchiengEd
Copy link
Contributor

@OchiengEd OchiengEd commented Mar 24, 2025

Description

This code snippet was written in response to a discussion in the Helm chart support brief. It aims to automate the detection of the content type served by a registry/v1 bundle and should be used with the cluster extension controller to unpack and deploy workloads.

The code will be connected with the existing code in subsequent pull requests.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 24, 2025
Copy link

netlify bot commented Mar 24, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 97c7e46
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67eac5975016400008c0649c
😎 Deploy Preview https://deploy-preview-1878--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 70.83333% with 21 lines in your changes missing coverage. Please review.

Project coverage is 68.95%. Comparing base (db164cc) to head (97c7e46).

Files with missing lines Patch % Lines
internal/shared/util/helm/chart.go 70.83% 15 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1878      +/-   ##
==========================================
- Coverage   68.98%   68.95%   -0.04%     
==========================================
  Files          66       67       +1     
  Lines        5243     5315      +72     
==========================================
+ Hits         3617     3665      +48     
- Misses       1395     1412      +17     
- Partials      231      238       +7     
Flag Coverage Δ
e2e 50.46% <ø> (-0.08%) ⬇️
unit 56.91% <70.83%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@OchiengEd OchiengEd marked this pull request as ready for review March 31, 2025 17:22
@OchiengEd OchiengEd requested a review from a team as a code owner March 31, 2025 17:22
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2025
@OchiengEd OchiengEd marked this pull request as draft March 31, 2025 17:42
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2025
@OchiengEd OchiengEd marked this pull request as ready for review April 1, 2025 14:44
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant