Skip to content

🌱 bump containers/image to v5.34.3 #1892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

joelanford
Copy link
Member

Description

Bump containers/image to v5.34.3.
This bump also requires a bump of controller-gen which we needed for its new --load-build-tags flag.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@joelanford joelanford requested a review from a team as a code owner April 1, 2025 22:21
Copy link

netlify bot commented Apr 1, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 10ec0fa
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67ec6bc800327600083585be
😎 Deploy Preview https://deploy-preview-1892--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joelanford joelanford force-pushed the bump-controller-gen-containers-image branch from 6873dd3 to b337ad6 Compare April 1, 2025 22:25
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.91%. Comparing base (db164cc) to head (10ec0fa).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1892      +/-   ##
==========================================
- Coverage   68.98%   68.91%   -0.08%     
==========================================
  Files          66       66              
  Lines        5243     5243              
==========================================
- Hits         3617     3613       -4     
- Misses       1395     1398       +3     
- Partials      231      232       +1     
Flag Coverage Δ
e2e 50.39% <ø> (-0.16%) ⬇️
unit 56.70% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joelanford joelanford force-pushed the bump-controller-gen-containers-image branch from b337ad6 to 10ec0fa Compare April 1, 2025 22:42
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2025
@camilamacedo86 camilamacedo86 added this pull request to the merge queue Apr 1, 2025
Merged via the queue into operator-framework:main with commit aa3d4d9 Apr 1, 2025
20 of 21 checks passed
@joelanford joelanford deleted the bump-controller-gen-containers-image branch April 2, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants