🌱 proposing github-->prow reviewer/approver mapping #1894
+65
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jordan Keister <[email protected]>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
openshift-ci
bot
added
the
do-not-merge/invalid-owners-file
|
The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the operator-framework org. You can then trigger verification by writing
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1894 +/- ##
==========================================
- Coverage 68.96% 68.91% -0.06%
==========================================
Files 66 66
Lines 5243 5243
==========================================
- Hits 3616 3613 -3
- Misses 1396 1398 +2
- Partials 231 232 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
perdasilva
approved these changes
Apr 4, 2025
|
@grokspawn I'm knackered. Missed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to
This expands the existing CODEOWNERS file to prow's OWNERS/OWNER_ALIASES files in order to be able to support our contribution ladder.
This will work with openshift/release#63229 to inform automated merge control.
Methodology was, in general...
for approvers:
for reviewers:
NOTE: There is special attention and OWNERS* files in ./docs, where @michaelryanpeter is the only approver and all other role-holders are identified as reviewers.
!! THESE ROLES SHOULD NOT BE CONSIDERED AUTHORITATIVE/FINAL !!
If your name is listed against a role that you do not feel in good conscience you can fulfill, please let me know by review comment or slack messaging.
If your name is not listed and you feel it should be, please let me know by review comment or slack messaging, including which role you feel fits.
If anything requires further consensus, we will discuss during the weekly OLM Community and Issue Triage Meeting.
Reviewer Checklist