Skip to content

🌱 Add regression testing to rukpak/convert #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

perdasilva
Copy link
Contributor

Description

Adds a regression test to the convert package to help catch breaking changes

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@perdasilva perdasilva requested a review from a team as a code owner April 3, 2025 12:15
Copy link

netlify bot commented Apr 3, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit cd24e2b
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67ee878e09a23d0008354999
😎 Deploy Preview https://deploy-preview-1895--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@perdasilva perdasilva changed the title 🌱 add regression testing 🌱 Add regression testing to rukpak/convert Apr 3, 2025
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.91%. Comparing base (d3aec37) to head (cd24e2b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1895      +/-   ##
==========================================
- Coverage   68.96%   68.91%   -0.06%     
==========================================
  Files          66       66              
  Lines        5243     5243              
==========================================
- Hits         3616     3613       -3     
- Misses       1396     1398       +2     
- Partials      231      232       +1     
Flag Coverage Δ
e2e 50.39% <ø> (-0.16%) ⬇️
unit 56.68% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@perdasilva perdasilva force-pushed the add-convert-regression-tests branch 2 times, most recently from 5e87081 to 2dc0939 Compare April 3, 2025 13:01
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva force-pushed the add-convert-regression-tests branch from 055019c to f86ff78 Compare April 3, 2025 13:04
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva force-pushed the add-convert-regression-tests branch from f86ff78 to cd24e2b Compare April 3, 2025 13:05
@dtfranz dtfranz added this pull request to the merge queue Apr 3, 2025
Merged via the queue into operator-framework:main with commit 23b9cdc Apr 3, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants