Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add package name validation function #1901

Merged

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented Apr 4, 2025

Description

Adds a bundle validation check against the package name to ensure it is defined in the RegistryV1 bundle structure. And does some tidying adding array pre-allocations

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@perdasilva perdasilva requested a review from a team as a code owner April 4, 2025 15:11
Copy link

netlify bot commented Apr 4, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit b103288
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67eff82ab55e540008c156af
😎 Deploy Preview https://deploy-preview-1901--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva force-pushed the add-package-name-check branch from 4c1608f to b103288 Compare April 4, 2025 15:18
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.22%. Comparing base (115a122) to head (b103288).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1901      +/-   ##
==========================================
+ Coverage   69.21%   69.22%   +0.01%     
==========================================
  Files          67       67              
  Lines        5302     5307       +5     
==========================================
+ Hits         3670     3674       +4     
- Misses       1399     1400       +1     
  Partials      233      233              
Flag Coverage Δ
e2e 50.55% <62.50%> (+0.06%) ⬆️
unit 57.00% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joelanford joelanford added this pull request to the merge queue Apr 4, 2025
Merged via the queue into operator-framework:main with commit 1f0b4f2 Apr 4, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants