Skip to content

🌱 Add more unit testing around rukpak/convert #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025

Conversation

perdasilva
Copy link
Contributor

Description

Adds additional unit testing around rukpak/convert to facilitate the upcoming refactoring towards a bundle renderer

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@perdasilva perdasilva requested a review from a team as a code owner April 10, 2025 08:00
Copy link

netlify bot commented Apr 10, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 43a49ba
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67f7d28b35ce940008b370b5
😎 Deploy Preview https://deploy-preview-1912--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 10, 2025

Codecov Report

Attention: Patch coverage is 91.11111% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.51%. Comparing base (0bcdd61) to head (43a49ba).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...operator-controller/rukpak/util/testing/testing.go 91.11% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1912      +/-   ##
==========================================
+ Coverage   69.33%   69.51%   +0.18%     
==========================================
  Files          67       68       +1     
  Lines        5312     5357      +45     
==========================================
+ Hits         3683     3724      +41     
- Misses       1397     1401       +4     
  Partials      232      232              
Flag Coverage Δ
e2e 50.61% <ø> (-0.08%) ⬇️
unit 57.43% <91.11%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva force-pushed the convert-unit-testing branch from 60650df to 43a49ba Compare April 10, 2025 14:15
@camilamacedo86 camilamacedo86 added this pull request to the merge queue Apr 11, 2025
@camilamacedo86 camilamacedo86 removed this pull request from the merge queue due to a manual request Apr 11, 2025
@perdasilva perdasilva added this pull request to the merge queue Apr 11, 2025
Merged via the queue into operator-framework:main with commit ed205c5 Apr 11, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants